Page MenuHomeFreeBSD
Differential D30056

pf: Remove DIOCCLRSTATES and DIOCKILLSTATES
ClosedPublic
Actions

Authored by kp on Apr 30 2021, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 8:37 PM
Unknown Object (File)
Fri, Apr 5, 8:35 PM
Unknown Object (File)
Mar 10 2024, 11:14 AM
Unknown Object (File)
Mar 7 2024, 6:25 PM
Unknown Object (File)
Mar 7 2024, 6:25 PM
Unknown Object (File)
Mar 7 2024, 6:18 PM
Unknown Object (File)
Mar 7 2024, 6:14 PM
Unknown Object (File)
Jan 3 2024, 4:00 AM
View All 34 Files
Subscribers
ae
bcr
farrokhi
glebius
imp
melifaro
mjg
pauamma_gundo.com

Details

Reviewers
mjg
pauamma_gundo.com
Group Reviewers
network
manpages
Commits
rG2e8edbc285cf: pf: Remove DIOCCLRSTATES and DIOCKILLSTATES
Summary

These now have nvlist based alternatives, so remove them.

MFC after: never
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Apr 30 2021, 5:33 PM
Herald added a reviewer: manpages. · View Herald TranscriptApr 30 2021, 5:33 PM
Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald Transcript
kp requested review of this revision.Apr 30 2021, 5:33 PM
Harbormaster completed remote builds in B38946: Diff 88435.Apr 30 2021, 5:33 PM
kp added a parent revision: D30055: pfctl: Start using DIOCKILLSTATESNV.Apr 30 2021, 5:33 PM
kp added a child revision: D30057: authpf: Start using libpfctl.
bcr accepted this revision as: manpages.Apr 30 2021, 6:50 PM
bcr added a subscriber: bcr.

OK for the man page part of the change.

kp updated this revision to Diff 119701.Mar 31 2023, 7:20 AM
  • rebase

I'm working on making libpfctl available for 12.4 and 13.1 as well, and intend
to land this change prior to the 14.0 release.

Herald added a subscriber: glebius. · View Herald TranscriptMar 31 2023, 7:20 AM
Harbormaster completed remote builds in B50697: Diff 119701.Mar 31 2023, 7:20 AM
kp added a comment.Aug 27 2023, 3:04 PM

I clearly didn't land this for 14, but now that we've branched I expect to rebase this and land the removal of these calls (and likely a few others) in 15.
Users of these calls are advised to migrate to libpfctl.

mjg accepted this revision.Aug 27 2023, 4:12 PM
mjg added a subscriber: mjg.

I'm all for reducing tech debt and complexity in the area.

It gets in the way of other work.

This revision is now accepted and ready to land.Aug 27 2023, 4:12 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Aug 27 2023, 5:32 PM
pauamma_gundo.com added inline comments.
share/man/man4/pf.4
344

Shouldn't that be present in nvlist pf_kill below? Or am I missing something?

kp added inline comments.Aug 28 2023, 1:30 PM
share/man/man4/pf.4
344

nvlists are not structures, so the 'killed' field is not present in the request, only in the response from the kernel.

pauamma_gundo.com accepted this revision.Aug 28 2023, 11:30 PM

With .Dd bumped (fixable on commit), manual page change LGTM.

share/man/man4/pf.4
29

Bump.

Closed by commit rG2e8edbc285cf: pf: Remove DIOCCLRSTATES and DIOCKILLSTATES (authored by kp). · Explain WhyAug 29 2023, 9:02 AM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG2e8edbc285cf: pf: Remove DIOCCLRSTATES and DIOCKILLSTATES.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
45 lines
sys/
net/
2 lines
netpfil/
pf/
50 lines

Diff 126627

View Options

share/man/man4/pf.4

Loading...
View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf_ioctl.c

Loading...