Page MenuHomeFreeBSD

pf: Remove DIOCCLRSTATES and DIOCKILLSTATES
ClosedPublic

Authored by kp on Apr 30 2021, 5:33 PM.
Tags
None
Referenced Files
F98382147: D30056.diff
Thu, Oct 3, 6:38 AM
Unknown Object (File)
Sat, Sep 28, 2:05 AM
Unknown Object (File)
Fri, Sep 27, 4:34 PM
Unknown Object (File)
Fri, Sep 27, 8:55 AM
Unknown Object (File)
Wed, Sep 11, 8:12 AM
Unknown Object (File)
Tue, Sep 10, 8:04 AM
Unknown Object (File)
Mon, Sep 9, 12:52 AM
Unknown Object (File)
Sun, Sep 8, 4:02 PM

Details

Summary

These now have nvlist based alternatives, so remove them.

MFC after: never
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Apr 30 2021, 5:33 PM
bcr added a subscriber: bcr.

OK for the man page part of the change.

  • rebase

I'm working on making libpfctl available for 12.4 and 13.1 as well, and intend
to land this change prior to the 14.0 release.

I clearly didn't land this for 14, but now that we've branched I expect to rebase this and land the removal of these calls (and likely a few others) in 15.
Users of these calls are advised to migrate to libpfctl.

mjg added a subscriber: mjg.

I'm all for reducing tech debt and complexity in the area.

It gets in the way of other work.

This revision is now accepted and ready to land.Aug 27 2023, 4:12 PM
pauamma_gundo.com added inline comments.
share/man/man4/pf.4
344

Shouldn't that be present in nvlist pf_kill below? Or am I missing something?

share/man/man4/pf.4
344

nvlists are not structures, so the 'killed' field is not present in the request, only in the response from the kernel.

With .Dd bumped (fixable on commit), manual page change LGTM.

share/man/man4/pf.4
29

Bump.

This revision was automatically updated to reflect the committed changes.