Page MenuHomeFreeBSD
Differential D30054

pf: Introduce DIOCKILLSTATESNV
ClosedPublic
Actions

Authored by kp on Apr 30 2021, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 3:18 PM
Unknown Object (File)
Mon, Feb 24, 3:26 PM
Unknown Object (File)
Feb 17 2025, 2:01 AM
Unknown Object (File)
Feb 16 2025, 8:13 AM
Unknown Object (File)
Feb 4 2025, 9:25 AM
Unknown Object (File)
Jan 29 2025, 9:21 AM
Unknown Object (File)
Jan 25 2025, 6:50 PM
Unknown Object (File)
Jan 11 2025, 4:52 AM
View All Files
Subscribers
ae
farrokhi
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
Commits
rGe25df666069d: pf: Introduce DIOCKILLSTATESNV
rG1cbb276258a4: pf: Introduce DIOCKILLSTATESNV
rGe989530a09b6: pf: Introduce DIOCKILLSTATESNV
Summary

Introduce an nvlist based alternative to DIOCKILLSTATES.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
net/
1 line
netpfil/
pf/
110 lines

Diff 88867

View Options

sys/net/pfvar.h

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
#define U8_C(x) x ## U #define U8_C(x) x ## U
#define S16_C(x) x #define S16_C(x) x
#define U16_C(x) x ## U #define U16_C(x) x ## U
#define S32_C(x) x #define S32_C(x) x
#define U32_C(x) x ## U #define U32_C(x) x ## U
#define S64_C(x) x ## LL #define S64_C(x) x ## LL
#define U64_C(x) x ## ULL #define U64_C(x) x ## ULL
/*
* BUILD_BUG_ON() can happen inside functions where _Static_assert() does not
* seem to work. Use old-schoold-ish CTASSERT from before commit
* a3085588a88fa58eb5b1eaae471999e1995a29cf but also make sure we do not
* end up with an unused typedef or variable. The compiler should optimise
* it away entirely.
*/
#define _O_CTASSERT(x) _O__CTASSERT(x, __LINE__)
#define _O__CTASSERT(x, y) _O___CTASSERT(x, y)
#define _O___CTASSERT(x, y) while (0) { \
hselaskyUnsubmitted
Not Done
Inline Actions

Should this be enclosed with while (0) and not "do { } while (0) "?

hselasky: Should this be enclosed with while (0) and not "do { } while (0) "?
bzAuthorUnsubmitted
Done
Inline Actions

Would a while (0) { } be optimized out without ever entering the block because it can never happen?

bz: Would a while (0) { } be optimized out without ever entering the block because it can never…
hselaskyUnsubmitted
Not Done
Inline Actions

Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.

hselasky: Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.
typedef char __assert_line_ ## y[(x) ? 1 : -1]; \
__assert_line_ ## y _x; \
_x[0] = '\0'; \
}
#define BUILD_BUG() do { CTASSERT(0); } while (0) #define BUILD_BUG() do { CTASSERT(0); } while (0)
#define BUILD_BUG_ON(x) CTASSERT(!(x)) #define BUILD_BUG_ON(x) _O_CTASSERT(!(x))
#define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x) #define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x)
#define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x)) #define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x))
#define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); } #define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); }
extern const volatile int lkpi_build_bug_on_zero; extern const volatile int lkpi_build_bug_on_zero;
#define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0) #define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0)
#define BUG() panic("BUG at %s:%d", __FILE__, __LINE__) #define BUG() panic("BUG at %s:%d", __FILE__, __LINE__)
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines
View Options

sys/netpfil/pf/pf_ioctl.c

Show First 20 Lines • Show All 83 Lines • ▼ Show 20 Lines
#define U8_C(x) x ## U #define U8_C(x) x ## U
#define S16_C(x) x #define S16_C(x) x
#define U16_C(x) x ## U #define U16_C(x) x ## U
#define S32_C(x) x #define S32_C(x) x
#define U32_C(x) x ## U #define U32_C(x) x ## U
#define S64_C(x) x ## LL #define S64_C(x) x ## LL
#define U64_C(x) x ## ULL #define U64_C(x) x ## ULL
/*
* BUILD_BUG_ON() can happen inside functions where _Static_assert() does not
* seem to work. Use old-schoold-ish CTASSERT from before commit
* a3085588a88fa58eb5b1eaae471999e1995a29cf but also make sure we do not
* end up with an unused typedef or variable. The compiler should optimise
* it away entirely.
*/
#define _O_CTASSERT(x) _O__CTASSERT(x, __LINE__)
#define _O__CTASSERT(x, y) _O___CTASSERT(x, y)
#define _O___CTASSERT(x, y) while (0) { \
hselaskyUnsubmitted
Not Done
Inline Actions

Should this be enclosed with while (0) and not "do { } while (0) "?

hselasky: Should this be enclosed with while (0) and not "do { } while (0) "?
bzAuthorUnsubmitted
Done
Inline Actions

Would a while (0) { } be optimized out without ever entering the block because it can never happen?

bz: Would a while (0) { } be optimized out without ever entering the block because it can never…
hselaskyUnsubmitted
Not Done
Inline Actions

Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.

hselasky: Yes, with -O2, but after parsing the code. So I believe any asserts will trigger.
typedef char __assert_line_ ## y[(x) ? 1 : -1]; \
__assert_line_ ## y _x; \
_x[0] = '\0'; \
}
#define BUILD_BUG() do { CTASSERT(0); } while (0) #define BUILD_BUG() do { CTASSERT(0); } while (0)
#define BUILD_BUG_ON(x) CTASSERT(!(x)) #define BUILD_BUG_ON(x) _O_CTASSERT(!(x))
#define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x) #define BUILD_BUG_ON_MSG(x, msg) BUILD_BUG_ON(x)
#define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x)) #define BUILD_BUG_ON_NOT_POWER_OF_2(x) BUILD_BUG_ON(!powerof2(x))
#define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); } #define BUILD_BUG_ON_INVALID(expr) while (0) { (void)(expr); }
extern const volatile int lkpi_build_bug_on_zero; extern const volatile int lkpi_build_bug_on_zero;
#define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0) #define BUILD_BUG_ON_ZERO(x) ((x) ? lkpi_build_bug_on_zero : 0)
#define BUG() panic("BUG at %s:%d", __FILE__, __LINE__) #define BUG() panic("BUG at %s:%d", __FILE__, __LINE__)
▲ Show 20 Lines • Show All 538 Lines • Show Last 20 Lines