Page MenuHomeFreeBSD

bhyve: Support setting the disk serial number for VirtIO block devices.
ClosedPublic

Authored by jhb on Sep 16 2021, 1:57 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Sep 16 2021, 1:58 PM
bcr added a subscriber: bcr.

OK from manpages.

jhb added a subscriber: pmooney_pfmooney.com.

@chuck, would you be able to test this easily?

Whoops, sorry, this isn't NVMe. :)

Since the "serial" taken from the configuration is directly copied to become the virtio-blk device's ident, should we call this "ident" simply? Looks good to me otherwise.

EDIT: I missed the fact that it was obtained from Illumos.

I think the goal was to also be similar to the name used for the AHCI and NVMe device models which both use "ser" for this.

allanjude added a subscriber: allanjude.

Reviewed By: allanjude

This revision is now accepted and ready to land.Sep 16 2021, 6:57 PM
In D31983#721639, @jhb wrote:

I think the goal was to also be similar to the name used for the AHCI and NVMe device models which both use "ser" for this.

Right - it was added as ser to match the others. Accepting the alternative of serial is there because that's what some illumos distributions had before the configuration management refactoring.

Apologies for getting to this late, but I tested this with ser, serial, and with no options. Seemed to work as expected