Page MenuHomeFreeBSD

Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'
Needs ReviewPublic

Authored by mr on Mar 28 2021, 6:57 PM.

Details

Reviewers
None
Group Reviewers
manpages
bhyve
Summary
PR:             246121
Submitted by:   koinec@yahoo.co.jp
MFC after:      2 weeks

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mr requested review of this revision.Mar 28 2021, 6:58 PM

I only checked the doc portion of the change. I generally like this feature and look forward to using it myself.
A few suggestions on the text. Did you check the manpage with "mandoc -Tlint" and textproc/igor? They usually give some good recommendations.

usr.sbin/bhyve/bhyve.8
163

You need a line break after the sentence stop. Maybe you can also put the sentence in () in the first one or describe a bit more why (or in which circumstances) it is not working to make it a sentence of its own?

164

The use of "you" is discouraged. You could write "When using a VNC client..., there is no need to ..."

165

Same here.

mr retitled this revision from Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K' to Append Keyboard Layout specified option for using VNC. Part two: Append bhyve -K option for specified keyboard layout with layout setting files every languages. Since the cmd option '-k' was used in the meantime I changed it to '-K'.
mr changed the repository for this revision from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.

Update bhyve.8 to reflect comments.

OK for the man page part of the change.