PR: 246121 Submitted by: email@example.com MFC after: 2 weeks
- Group Reviewers
- R10:19eaa01beaba: Append Keyboard Layout specified option for using VNC.
I only checked the doc portion of the change. I generally like this feature and look forward to using it myself.
A few suggestions on the text. Did you check the manpage with "mandoc -Tlint" and textproc/igor? They usually give some good recommendations.
You need a line break after the sentence stop. Maybe you can also put the sentence in () in the first one or describe a bit more why (or in which circumstances) it is not working to make it a sentence of its own?
The use of "you" is discouraged. You could write "When using a VNC client..., there is no need to ..."
This should be setting a config variable instead so that config files can set it, and the code to fetch it should not use the global variable, but fetch the relevant config setting instead. You'd also need to document the new config variable in bhyve_config.5.
I would perhaps use 'Keys' instead of 'Key' when adding a heading for multiple entries.
Use MAX_PATHNAME (or whatever the right constant is)
This is probably simpler as a single call to snprintf(). strlcat would let you avoid the complicated length expression, but using snprintf() is even simpler.
Do you mean that only values that match filenames in that directory are valid?
Per https://docs.freebsd.org/en/books/fdp-primer/manual-pages/#manual-pages-markup (last item in section 10.3.5.2. See also mdoc(7).
For consistency with capitalization below.
See my comments about -K in bhyve(8) above.