• Add the tests user, and unprivileged user from the default kyua config.

In D24103#530200, @arichardson wrote:

The package also creates a tests user. Not sure if that is still required.

Ah, the CI error was my fault and caused by the mtree error. Working build here https://cirrus-ci.com/task/4696992890748928

• Fix a typo in the mtree file for kyua.

New CI job with tweak so the sources are available https://cirrus-ci.com/task/5382784613089280?command=package#L1883

The patch assumes lutok and kyua are extracted in contrib. If you want to test you can clone the repos there.

CI build in progress https://cirrus-ci.com/task/6332905735585792

I saw these using a tip of tree llvm as a cross toolchain to build FreeBSD. Anything with WARNS>0 includes -Wsystem-headers and so C++ programs failed to compile.

• Declare mr_fixed a the top of the function.
• Add comma

• Rebase
• Use a compound literal to move decleration to the top of the function.
• Move struct mmap_req to syscallsubr.h.

• Don't copy too much.

• Rebase
• Check copyin's error code.
• Don't free a stack pointer.

This change is required to add a working GENERIC-NODEBUG kernel.

This makes sense to me. I think I might have missed this due to a formatting bug in the posix manpage.

Thanks for the submission, I'll commit shortly (with a small tweak to the lua bits).

It seems like there's a missing change to usr.bin/Makefile.

In D23124#514183, @brooks wrote:

Won't that completely stop working the moment we remove gcc 4.2.1?

In D23124#514059, @imp wrote:

In D23124#514030, @jhb wrote:

So one question I have is if 'make xdev' makes sense in a clang world? clang is already a cross-compiler via -target. Probably not for this change, but if 'make xdev' is now obsolete it might be nice to GC those bits as a followup.

It's used in package building. There, cc needs to generate the target's binaries w/o a lot of ability to intercept. We'd have to rework that stuff to be a series of shell scripts to be a drop in. This is in the context of the arm jail on a amd64 host. We drop the amd64 binaries into that for better performance. so definitely not for this change.

You seem to be manually uploading diffs rather than using arcanist and the diff is now against your previous version not against the freebsd tree...

This should be submitted to NetBSD so we don't have to maintain a local diff.

Bah, I did indeed misread the code.

Looks great

I've done limited testing (booted an amd64) system with this patch. I chose to remove kern_mmap_fpcheck entirely, but could restore it if that feels like a cleaner option.

LGTM