Page MenuHomeFreeBSD

Define SCTL_MASK32 when COMPAT_FREEBSD32 is defined.
ClosedPublic

Authored by brooks on Feb 18 2020, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 6:33 PM
Unknown Object (File)
Dec 30 2023, 12:52 AM
Unknown Object (File)
Dec 23 2023, 12:33 AM
Unknown Object (File)
Nov 6 2023, 8:23 PM
Unknown Object (File)
Aug 17 2023, 8:37 PM
Unknown Object (File)
Jun 25 2023, 12:19 PM
Unknown Object (File)
Jun 17 2023, 4:49 AM
Unknown Object (File)
May 29 2023, 7:59 PM
Subscribers
None

Details

Summary

Remove the list of architectures and depend on COMPAT_FREEBSD32 which is
defined (if relevent) in opt_global.h and thus defined everywhere in
the kernel.

This is a minor change in behavior in that 32-bit compat for sysctls now
depends on COMPAT_FREEBSD32 rather than on the potential for 32-bit
compat support. The prior arrangement may have been part of an attempt
to allow 32-bit compat to be loadable, but such attempts are doomed to
failure (due to the fact that ioctls have no meaning without the
associated file descriptor) without vastly more refactoring and some
sort of COMPAT_FREEBSD32_SUPPORT option.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Of course, I'd rather we just kill SCTL_MASK32 entirely and use SV_PROC_FLAG checks to replace it, but that's a separate (and larger) change we've already discussed in person.

This revision is now accepted and ready to land.Feb 24 2020, 7:53 PM