Page MenuHomeFreeBSD

Build hard-float lib32 for mips64hf/mips64elhf
ClosedPublic

Authored by arichardson on Jan 17 2020, 11:11 AM.
Tags
None
Referenced Files
F153734248: D23229.id67348.diff
Thu, Apr 23, 7:47 AM
Unknown Object (File)
Mon, Apr 20, 9:36 AM
Unknown Object (File)
Mon, Apr 6, 6:07 AM
Unknown Object (File)
Fri, Apr 3, 10:09 AM
Unknown Object (File)
Fri, Mar 27, 4:57 AM
Unknown Object (File)
Mar 21 2026, 4:50 AM
Unknown Object (File)
Mar 20 2026, 9:20 PM
Unknown Object (File)
Mar 20 2026, 3:07 PM

Details

Summary

This should fix linker error when building with clang+lld.

Test Plan

lib32 now builds with -mhard-float instead of -msoft-float

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2020, 11:50 AM

Yes, I was testing this locally, though without the :=, just a plain =. I was testing it as part of a make tinderbox run though that is only on amd64 and hasn't gotten to mips, so hadn't seen breakage that would require :=.

In D23229#509463, @jhb wrote:

Yes, I was testing this locally, though without the :=, just a plain =. I was testing it as part of a make tinderbox run though that is only on amd64 and hasn't gotten to mips, so hadn't seen breakage that would require :=.

Yeah I got a recursive variable definition error with = so I changed it to :=

jhb added inline comments.
share/mk/bsd.compat.mk
169 ↗(On Diff #66902)

Ah, because this would recurse. Arguably these two assignments should probably be using :=? Your patch is fine for now though.