Page MenuHomeFreeBSD

Build hard-float lib32 for mips64hf/mips64elhf
ClosedPublic

Authored by arichardson on Jan 17 2020, 11:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 9:36 PM
Unknown Object (File)
Feb 9 2024, 6:01 AM
Unknown Object (File)
Jan 30 2024, 2:13 AM
Unknown Object (File)
Jan 5 2024, 11:37 AM
Unknown Object (File)
Jan 5 2024, 11:37 AM
Unknown Object (File)
Jan 5 2024, 11:37 AM
Unknown Object (File)
Jan 5 2024, 11:09 AM
Unknown Object (File)
Dec 28 2023, 5:49 PM

Details

Summary

This should fix linker error when building with clang+lld.

Test Plan

lib32 now builds with -mhard-float instead of -msoft-float

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 17 2020, 11:50 AM

Yes, I was testing this locally, though without the :=, just a plain =. I was testing it as part of a make tinderbox run though that is only on amd64 and hasn't gotten to mips, so hadn't seen breakage that would require :=.

In D23229#509463, @jhb wrote:

Yes, I was testing this locally, though without the :=, just a plain =. I was testing it as part of a make tinderbox run though that is only on amd64 and hasn't gotten to mips, so hadn't seen breakage that would require :=.

Yeah I got a recursive variable definition error with = so I changed it to :=

jhb added inline comments.
share/mk/bsd.compat.mk
169 ↗(On Diff #66902)

Ah, because this would recurse. Arguably these two assignments should probably be using :=? Your patch is fine for now though.