Page MenuHomeFreeBSD

2020-02-29 rm GCC 4.2.1 build infrastructure
AcceptedPublic

Authored by emaste on Fri, Jan 10, 5:28 PM.

Details

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

emaste created this revision.Fri, Jan 10, 5:28 PM
brooks added a subscriber: brooks.Fri, Jan 10, 10:23 PM
brooks added inline comments.
Makefile.inc1
255

Can drop parenthesis.

3016

I'm confused what removed .if this aligns with.

3353

Does XDEV make sense without a compiler?

emaste added inline comments.Sun, Jan 12, 5:32 PM
Makefile.inc1
255

Will do in next update.

3016

It doesn't; seems it came from a mis-rebase. In the next update I'll combine the MK_CXX and MK_LIBCPLUSPLUS above.

lwhsu added a subscriber: lwhsu.Mon, Jan 13, 9:09 AM
emaste added inline comments.Mon, Jan 13, 2:32 PM
Makefile.inc1
3353

removing ${_gcc} is needed anyway; what do you suggest we do w/ XDEV if MK_CLANG==no?

emaste updated this revision to Diff 66683.Mon, Jan 13, 2:33 PM

minor tweaks from @brooks

imp added inline comments.Mon, Jan 13, 2:38 PM
Makefile.inc1
3353

It makes no sense. It should fail in some way. Xdev is there to make the compiler and toolchain stuff. It was only a variable here since clang was introduced. It used to be unconditional gcc.

emaste added inline comments.Mon, Jan 13, 3:35 PM
Makefile.inc1
3353

This issue predates my proposed change though; archs without either clang or gcc 4.2.1 (like riscv) would have had this problem already.

brooks accepted this revision.Tue, Jan 14, 4:27 AM
This revision is now accepted and ready to land.Tue, Jan 14, 4:27 AM
imp accepted this revision.Tue, Jan 14, 5:45 AM
imp added inline comments.
Makefile.inc1
3353

It's ok, I guess. It only makes sense for in tree toolchain... we can leave it likes this...

emaste added inline comments.Tue, Jan 14, 3:38 PM
Makefile.inc1
3353

I think we could/should still do something about it, but it can happen before or after this change. Probably if any of ${_clang_libs}, ${_lld}, ${_binutils}, ${_elftctools}, ${_clang} are empty it could be a .error. Well, empty ${_binutils} is OK depending on arch.

jhb added inline comments.Tue, Jan 14, 5:46 PM
Makefile.inc1
184

We should probably rm the bits to try to set CROSS_BINUTILS_PREFIX. aarch64 and riscv64 were the users of this before and they both now use LLD. I think it won't conflict. I'll see if I can do that as a separate change sooner.

One thing we want to make sure of today is that right now 'make buildworld' for mips and sparc64 should be failing unless someone has manually set WITH_GCC to yes. Not sure where that needs to happen (either here or src.opts.mk)

We should probably rm the bits to try to set CROSS_BINUTILS_PREFIX. aarch64 and riscv64 were the users of this before and they both now use LLD. I think it won't conflict. I'll see if I can do that as a separate change sooner.

I don't think it will conflict, and in any case I'll rebase this over the change if it goes in first.