mei: add debug-probe driver for Intel ME/HECI firmware status
Needs ReviewPublic
Actions

Authored by guest-seuros on Sat, Aug 15, 8:12 PM.

Details

Reviewers

adrian
imp
dteske
kbowling
ziaee

Summary

Add an amd64-only diagnostic driver that reads ME Host Firmware
Status registers from PCI configuration space without mapping the
messaging BAR.

Select the HFS register count per device generation, decode sparse
HFS1 state, mode, and error fields, and expose raw and summarized
status via sysctl. Register an ISA-side meifd probe for supported
RCBA/FD2 generations so firmware-hidden HECI functions can be
diagnosed.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 75614
Build 72497: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Sat, Aug 15, 8:12 PM

Herald added a subscriber: ziaee. · View Herald TranscriptSat, Aug 15, 8:12 PM

guest-seuros requested review of this revision.Sat, Aug 15, 8:12 PM

Harbormaster completed remote builds in B75614: Diff 184110.Sat, Aug 15, 8:12 PM

adrian added a project: drivers.Sat, Aug 15, 8:13 PM

adrian added inline comments.

sys/dev/mei/mei_pci.c
34	Do you mind moving register definitions into mei_reg.h ? the strings are fine in the .c file as-is.
444	should this be a separate source file?

split files

Harbormaster completed remote builds in B75615: Diff 184111.Sat, Aug 15, 8:34 PM

guest-seuros added a reviewer: kbowling.Sat, Aug 15, 8:37 PM

kbowling added inline comments.Sat, Aug 15, 9:22 PM

share/man/man4/mei.4
67	This is probably more appropriate for the commit message not the man page
74	This kind of detail is probably more appropriate for a block comment inside the source code. The man page should just list what PCHs are supported.