Page MenuHomeFreeBSD
Differential D54266

iwlwifi: Don't compile for clang before 19
AcceptedPublic
Actions

Authored by brooks on Wed, Dec 17, 11:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 17, 5:49 PM
Unknown Object (File)
Wed, Dec 17, 5:49 PM
Unknown Object (File)
Wed, Dec 17, 5:49 PM
Unknown Object (File)
Wed, Dec 17, 5:14 PM
Subscribers
dumbbell

Details

Reviewers
bz
imp
Summary

The linux kpi requires __builtin_popcountg which was introduced in Clang

  1. With this change I can build an aarch64 GENERIC kernel with the

llvm-morello toolchain (based on LLVM 17).

Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 69328
Build 66211: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Wed, Dec 17, 11:53 AM
brooks created this revision.
Harbormaster completed remote builds in B69327: Diff 168249.Wed, Dec 17, 11:53 AM
brooks updated this revision to Diff 168250.Wed, Dec 17, 11:56 AM

Bump compiler version to 19.1.0 since development versions may not
include __builtin_popcountg.

Harbormaster completed remote builds in B69328: Diff 168250.Wed, Dec 17, 11:56 AM
bz requested changes to this revision.Thu, Dec 18, 2:17 AM

Can we abandon this.

There are at least two versions floating around (at least one in review if I remember correctly) which don't require the silly checks.
Sorry, gcc is still broken again since the day after this was added by @imp.

I'll find the reviews if needed if you are willing to review them?

This revision now requires changes to proceed.Thu, Dec 18, 2:17 AM
brooks added a comment.Thu, Dec 18, 3:40 PM

I don't care how it's fixed, but I will commit this pretty soon if a broader fix isn't added. The linuxkpi fix should never have been committed without a fallback.

bz accepted this revision.Thu, Dec 18, 9:59 PM
bz added a subscriber: dumbbell.

I'll deal with it after the fact; I don't think @dumbbell currently finds the time.
It's been 7cbc4d875971860d941cc15d7f42e6cfeffbfe66 ( https://reviews.freebsd.org/D50995 ) by @dumbbell for drm-kmod and had nothing to do with iwlwifi in first place.

This revision is now accepted and ready to land.Thu, Dec 18, 9:59 PM

Revision Contents
Changeset List

PathSize
sys/
modules/
4 lines

Diff 168250

View Options

sys/modules/Makefile

Loading...