Page MenuHomeFreeBSD
Differential D53703

iwx: clean up debugging around key add/set; comments on delete
ClosedPublic
Actions

Authored by adrian on Nov 12 2025, 2:50 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, May 12, 9:28 AM
Unknown Object (File)
Mon, May 11, 9:30 PM
Unknown Object (File)
Mon, May 11, 7:44 PM
Unknown Object (File)
Sat, May 9, 10:27 AM
Unknown Object (File)
Fri, May 8, 1:28 AM
Unknown Object (File)
Sun, May 3, 10:02 AM
Unknown Object (File)
Sat, May 2, 7:23 PM
Unknown Object (File)
Tue, Apr 28, 9:09 PM
View All 38 Files
Subscribers
imp

Details

Reviewers
thj
Group Reviewers
wireless
Commits
rG7d88ac0eb2d2: iwx: clean up debugging around key add/set; comments on delete
Summary
  • Add IWN_DEBUG_KEYMGMT as a debug flag
  • Convert DPRINTF(()) in key add/set to IWN_DPRINTF()
  • printf() -> net80211_vap_printf()
  • add braces around return value

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68562
Build 65445: arc lint + arc unit

Event Timeline

adrian created this revision.Nov 12 2025, 2:50 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 12 2025, 2:50 AM
adrian requested review of this revision.Nov 12 2025, 2:50 AM
Harbormaster completed remote builds in B68562: Diff 166271.Nov 12 2025, 2:50 AM
adrian added a parent revision: D52712: rtwn: migrate to new ieee80211 key data accessors.Nov 12 2025, 2:52 AM
adrian edited parent revisions, added: D53704: mtw: convert to new net80211 crypto key API; removed: D52712: rtwn: migrate to new ieee80211 key data accessors.Nov 12 2025, 3:01 AM
adrian added a child revision: D53721: iwx: fix and clean up suspend/resume path.Nov 12 2025, 9:05 PM
adrian added reviewers: wireless, thj.Nov 13 2025, 4:38 AM
adrian added a project: wireless.
thj accepted this revision.Nov 13 2025, 9:27 AM

Please update the bits available comment below keymgmt when you land this

This revision is now accepted and ready to land.Nov 13 2025, 9:27 AM
Closed by commit rG7d88ac0eb2d2: iwx: clean up debugging around key add/set; comments on delete (authored by adrian). · Explain WhyNov 14 2025, 2:37 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG7d88ac0eb2d2: iwx: clean up debugging around key add/set; comments on delete.

Revision Contents
Changeset List

PathSize
sys/
dev/
iwx/
38 lines
1 line

Diff 166271

View Options

sys/dev/iwx/if_iwx.c

Loading...
View Options

sys/dev/iwx/if_iwx_debug.h

Loading...