Makefile.inc1: Build openssl as a certctl dependency on old FreeBSD
ClosedPublic
Actions

Authored by markj on Aug 29 2025, 11:35 PM.

Details

Reviewers

kevans
des

Commits

rG13e7b21901a5: Makefile.inc1: Build openssl as a certctl dependency on old FreeBSD

Summary

X509_NAME_hash_ex() is not available in OpenSSL 1.x.

Reported by: syzbot+54c1e57e7184582a8f59@syzkaller.appspotmail.com
Fixes: c340ef28fd38 ("certctl: Reimplement in C")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 66694
Build 63577: arc lint + arc unit

Event Timeline

markj created this revision.Aug 29 2025, 11:35 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptAug 29 2025, 11:35 PM

markj requested review of this revision.Aug 29 2025, 11:35 PM

Harbormaster completed remote builds in B66694: Diff 161258.Aug 29 2025, 11:35 PM

markj retitled this revision from Makefile.inc1: Build certctl as a bootstrap tool on old FreeBSD to Makefile.inc1: Build openssl as a certctl dependency on old FreeBSD.Aug 30 2025, 3:30 PM

kevans added inline comments.Aug 30 2025, 3:39 PM

Makefile.inc1
2716	I believe this breaks cross-building from Linux unless the new addition is qualified with `${.MAKE.OS} != "Linux"` -- I didn't make any attempt to guess at endian-ness or anything for Linux, but the libcrypto build wants it.

Only change behaviour for FreeBSD

Harbormaster completed remote builds in B66697: Diff 161271.Aug 30 2025, 3:53 PM

Any further comments on or objections to the patch? I'd like to commit this soon: without it syzbot builds are broken since the syzbot host is running a quite old version of FreeBSD.

des accepted this revision.Sep 3 2025, 3:56 PM

This revision is now accepted and ready to land.Sep 3 2025, 3:56 PM

Closed by commit rG13e7b21901a5: Makefile.inc1: Build openssl as a certctl dependency on old FreeBSD (authored by markj). · Explain WhySep 3 2025, 4:15 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG13e7b21901a5: Makefile.inc1: Build openssl as a certctl dependency on old FreeBSD.