Differential D50691

net80211: update ieee80211_output_seqno_assign() to 802.11-2020
ClosedPublic
Actions

Authored by adrian on Jun 4 2025, 9:50 PM.

Details

Reviewers

Group Reviewers

wireless

Commits

rGdcd47304acb1: net80211: update ieee80211_output_seqno_assign() to 802.11-2020

Summary

Update ieee80211_output_seqno_assign() to support the transmitter
sequence number assignment outlined in 802.11-2020 10.3.2.14.2
(Transmitter Requirements).

Notably this correctly assigns the QoS NULL frames a seqno outside of
the TID seqno space.

Leave stub comments for the currently supported sequence
number decisions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64708
Build 61592: arc lint + arc unit

Event Timeline

adrian created this revision.Jun 4 2025, 9:50 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptJun 4 2025, 9:50 PM

adrian requested review of this revision.Jun 4 2025, 9:50 PM

Harbormaster completed remote builds in B64650: Diff 156555.Jun 4 2025, 9:50 PM

adrian added a parent revision: D50646: net80211: remove if_private.h from code that doesn't require it.Jun 4 2025, 9:51 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D50692: net80211: add support for sequence number offloading.Jun 5 2025, 12:20 AM

fix the seqno update routines to wrap things appropriately.
This bit me when doing some work on if_rsu

Harbormaster completed remote builds in B64708: Diff 156682.Jun 8 2025, 12:41 AM

bz added a subscriber: bz.Jun 8 2025, 11:01 PM

bz added inline comments.

sys/net80211/ieee80211_node.c
3153	This is not atomic. Is that okay?

adrian added inline comments.Jun 8 2025, 11:09 PM

sys/net80211/ieee80211_node.c
3153	Yup, it's either done under the net80211 TX lock or under the driver TX lock. One big part of the deferred/offloaded seqno work is to migrate it to the driver and force the driver to do it under a serialising lock - since for devices that need all the encap work done, (a) seqno assignment needs to be serialised from multiple concurrent senders into a given destination/TID, (b) TX IV crypto needs to be serialised, same conditions, and (c) 802.11 seqno / TX IV crypto/encap need to be done together so they don't get out of order.