Page MenuHomeFreeBSD

Makefile.inc1: Remove packagekernel non-NO_ROOT support
ClosedPublic

Authored by emaste on May 15 2025, 1:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 5, 6:49 PM
Unknown Object (File)
Wed, Jul 2, 8:11 PM
Unknown Object (File)
Wed, Jul 2, 5:13 AM
Unknown Object (File)
Fri, Jun 27, 3:06 PM
Unknown Object (File)
Thu, Jun 26, 10:47 AM
Unknown Object (File)
Thu, Jun 26, 2:32 AM
Unknown Object (File)
Wed, Jun 25, 7:06 AM
Unknown Object (File)
Wed, Jun 25, 5:32 AM
Subscribers

Details

Summary
As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute*
and package*") the other code path is unused, so remove it.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.
Makefile.inc1
1976

The difference between the now-removed block and the above is that the NO_ROOT case uses kernel.meta previously generated by distributekernel (tar @kernel.meta) vs tar . here.

Just remove the .if defined(NO_ROOT) -- packagekernel requires that distributekernel was run first, and distributekernel always generates a metalog.

Makefile.inc1
1974

this is just a nit in the diff output - there's still a .endif here; the diff just shows the one now at line 1973 as the one that remains.

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2025, 9:51 PM
This revision was automatically updated to reflect the committed changes.