Page MenuHomeFreeBSD

Makefile.inc1: Remove packagekernel non-NO_ROOT support
ClosedPublic

Authored by emaste on May 15 2025, 1:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 21, 3:26 AM
Unknown Object (File)
Fri, Nov 14, 3:11 AM
Unknown Object (File)
Oct 27 2025, 12:31 PM
Unknown Object (File)
Oct 27 2025, 12:31 PM
Unknown Object (File)
Oct 27 2025, 12:31 PM
Unknown Object (File)
Oct 27 2025, 12:31 PM
Unknown Object (File)
Oct 27 2025, 7:21 AM
Unknown Object (File)
Oct 24 2025, 1:52 AM
Subscribers

Details

Summary
As of commit 41adc5f29ba6 ("release: Always use NO_ROOT for distribute*
and package*") the other code path is unused, so remove it.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.
Makefile.inc1
1969

The difference between the now-removed block and the above is that the NO_ROOT case uses kernel.meta previously generated by distributekernel (tar @kernel.meta) vs tar . here.

Just remove the .if defined(NO_ROOT) -- packagekernel requires that distributekernel was run first, and distributekernel always generates a metalog.

Makefile.inc1
1967

this is just a nit in the diff output - there's still a .endif here; the diff just shows the one now at line 1973 as the one that remains.

This revision was not accepted when it landed; it landed in state Needs Review.May 23 2025, 9:51 PM
This revision was automatically updated to reflect the committed changes.