Differential D41957

Purge more stray embedded $FreeBSD$ strings
ClosedPublic
Actions

Authored by jhb on Sep 23 2023, 10:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 26, 4:01 AM

	Unknown Object (File)
	Sat, Dec 21, 2:26 AM

	Unknown Object (File)
	Sat, Dec 21, 2:23 AM

	Unknown Object (File)
	Fri, Dec 20, 5:26 PM

	Unknown Object (File)
	Nov 14 2024, 10:47 PM

	Unknown Object (File)
	Nov 10 2024, 1:23 AM

	Unknown Object (File)
	Nov 6 2024, 9:09 PM

	Unknown Object (File)
	Nov 6 2024, 9:09 PM

View All 51 Files

Subscribers

Details

Reviewers

imp
emaste
jilles
manu

Commits

rG260bab9f1e6f: Purge more stray embedded $FreeBSD$ strings
rGde270f81b246: Purge more stray embedded $FreeBSD$ strings
rGeba230afba49: Purge more stray embedded $FreeBSD$ strings

Summary

These do not use __FBSDID but instead use bare char arrays.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53692
Build 50583: arc lint + arc unit

Event Timeline

jhb created this revision.Sep 23 2023, 10:04 PM

Herald added a reviewer: jilles. · View Herald TranscriptSep 23 2023, 10:04 PM

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: glebius, dab, melifaro, bdragon. · View Herald Transcript

jhb requested review of this revision.Sep 23 2023, 10:04 PM

Harbormaster completed remote builds in B53692: Diff 127694.Sep 23 2023, 10:04 PM

jhb added a parent revision: D41956: lpr: Remove now unused fallback definition for __FBSDID.Sep 23 2023, 10:04 PM

jhb added a child revision: D41958: powerpc/generate-hfs.sh: Don't include $FreeBSD$ in prefix to uuencoded image.

Sorry for all the ditto

libexec/comsat/comsat.c
40	When do we finally get rid of these? Maybe now for the ones adjacent to FreeBSD? So in this case remove the full lint ifdef.
libexec/rpc.rstatd/rstat_proc.c
32	No obligation for copyright notice at all, so this can also be removed
sbin/dump/main.c
36	This one likely should be separate. I think we are OK, but we should do a separate analysis
sbin/dumpfs/dumpfs.c
51	Ditto to dump.c
sbin/ffsinfo/ffsinfo.c
49	Ditto to dump.c. especially since there are others listed
sbin/growfs/debug.c
40	This line?
sbin/ifconfig/ifconfig.c
35	Ditto dump.c
sbin/init/init.c
38	Ditto dump.c
sbin/mount/mount_fs.c
39	Ditto dump.c
sbin/mount_cd9660/mount_cd9660.c
43	Ditto dump.c
sbin/mount_unionfs/mount_unionfs.c
41	Ditto dump.c
sbin/umount/umount.c
36	Ditto dump.c
sys/netpfil/ipfilter/netinet/fil.c
107	Don't know what to think about ip filter scuft
usr.bin/locate/locate/locate.c
41	Ditto dump.c
usr.bin/morse/morse.c
37	Ditto dump.c
usr.bin/nfsstat/nfsstat.c
67	Ditto dump.c
usr.bin/number/number.c
34	Ditto dump.c
usr.bin/primes/primes.c
37	Ditto dump.c
usr.bin/printf/printf.c
44	Ditto dump.c
usr.bin/showmount/showmount.c
39	Ditto dump.c
usr.bin/tee/tee.c
36	Ditto dump.c
usr.bin/time/time.c
35	Ditto dump.c
usr.bin/ul/ul.c
36	Ditto dump.c
usr.bin/uniq/uniq.c
39	Ditto dump.c
usr.bin/yes/yes.c
36	Ditto dump.c
usr.sbin/config/main.cc
36	Ditto dump.c
usr.sbin/flowctl/flowctl.c
29	Kill this one?
usr.sbin/nfsd/nfsd.c
39	Ditto dump.c
usr.sbin/traceroute6/traceroute6.c
70	Ditto dump.c

This revision is now accepted and ready to land.Sep 23 2023, 10:36 PM

jhb added inline comments.Sep 23 2023, 10:45 PM

libexec/comsat/comsat.c
40	I think it would be best to axe other IDs in a separate pass from $FreeBSD$. I do think we should make a pass in main before 15.0. I'm not sure it's worth MFC'ing that though. Maybe to 14 if we do it "soon".

jhb added inline comments.Sep 23 2023, 10:55 PM

sbin/growfs/debug.c
40	I have no idea where that came from. It's probably not useful, but probably worth its own commit to cleanup? I think I found a $SourceForge$ in some file glebius wrote as well.

emaste accepted this revision.Sep 24 2023, 12:47 AM

Closed by commit rGeba230afba49: Purge more stray embedded $FreeBSD$ strings (authored by jhb). · Explain WhySep 25 2023, 8:40 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGeba230afba49: Purge more stray embedded $FreeBSD$ strings.

jhb added a commit: rGde270f81b246: Purge more stray embedded $FreeBSD$ strings.Nov 29 2023, 4:27 AM

jhb added a commit: rG260bab9f1e6f: Purge more stray embedded $FreeBSD$ strings.Dec 23 2023, 7:22 PM

Revision Contents
Changeset List

Path

Size

lib/

lib80211/

lib80211_regdomain.c

3 lines

libc/

net/

6 lines

powerpc/

gen/

5 lines

powerpc64/

gen/

5 lines

msun/

src/

4 lines

4 lines

5 lines

libexec/

atrun/

5 lines

3 lines

5 lines

comsat/

2 lines

fingerd/

2 lines

getty/

2 lines

2 lines

mknetid/

5 lines

5 lines

2 lines

rbootd/

2 lines

2 lines

2 lines

2 lines

2 lines

revnetgroup/

5 lines

parse_netgroup.c

5 lines

5 lines

rpc.rstatd/

2 lines

5 lines

rpc.rusersd/

5 lines

5 lines

rpc.sprayd/

5 lines

rtld-elf/

1 line

talkd/

2 lines

2 lines

2 lines

2 lines

2 lines

sbin/

dump/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

dumpfs/

2 lines

ffsinfo/

5 lines

fsck_msdosfs/

2 lines

2 lines

2 lines

2 lines

2 lines

fsdb/

5 lines

5 lines

fsirand/

5 lines

growfs/

5 lines

ifconfig/

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

2 lines

5 lines

5 lines

5 lines

5 lines

5 lines

init/

2 lines

mknod/

2 lines

mount/

2 lines

mount_cd9660/

2 lines

mount_msdosfs/

mount_msdosfs.c

5 lines

mount_nullfs/

2 lines

mount_unionfs/

mount_unionfs.c

3 lines

newfs_msdos/

5 lines

5 lines

nos-tun/

5 lines

restore/

2 lines

2 lines

2 lines

umount/

2 lines

stand/

libsa/

powerpc/

5 lines

sys/

netpfil/

ipfilter/

netinet/

1 line

1 line

1 line

1 line

usr.bin/

locate/

locate/

2 lines

mktemp/

5 lines

morse/

2 lines

nfsstat/

2 lines

number/

2 lines

primes/

2 lines

2 lines

2 lines

printf/

2 lines

showmount/

2 lines

tee/

2 lines

time/

2 lines

truncate/

3 lines

ul/

2 lines

uniq/

2 lines

units/

5 lines

yes/

2 lines

usr.sbin/

apmd/

5 lines

btxld/

5 lines

ckdist/

5 lines

config/

2 lines

2 lines

2 lines

2 lines

flowctl/

5 lines

keyserv/

5 lines

2 lines

2 lines

mptable/

5 lines

nfsd/

2 lines

pciconf/

5 lines

5 lines

5 lines

pw/

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

5 lines

rpc.lockd/

1 line

rpc.statd/

5 lines

rpc.umntall/

5 lines

rpc.ypupdated/

2 lines

spray/

5 lines

traceroute6/

2 lines

vidcontrol/

5 lines

5 lines

Diff 127694

lib/lib80211/lib80211_regdomain.c

Loading...

lib/libc/net/nslexer.l

Loading...

lib/libc/powerpc/gen/syncicache.c

Loading...

lib/libc/powerpc64/gen/syncicache.c

Loading...

lib/msun/src/e_sqrtf.c

Loading...

lib/msun/src/s_modf.c

Loading...

lib/msun/src/w_cabsf.c

Loading...

libexec/atrun/atrun.c

Loading...

libexec/atrun/gloadavg.h

Loading...

libexec/atrun/gloadavg.c

Loading...

libexec/comsat/comsat.c

Loading...

libexec/fingerd/fingerd.c

Loading...

libexec/getty/init.c

Loading...

libexec/getty/subr.c

Loading...

libexec/mknetid/hash.c

Loading...

libexec/mknetid/mknetid.c

Loading...

libexec/mknetid/parse_group.c

Loading...

libexec/rbootd/bpf.c

Loading...

libexec/rbootd/conf.c

Loading...

libexec/rbootd/parseconf.c

Loading...

libexec/rbootd/rmpproto.c

Loading...

libexec/rbootd/utils.c

Loading...

libexec/revnetgroup/hash.c

Loading...

libexec/revnetgroup/parse_netgroup.c

Loading...

libexec/revnetgroup/revnetgroup.c

Loading...

libexec/rpc.rstatd/rstat_proc.c

Loading...

libexec/rpc.rstatd/rstatd.c

Loading...

libexec/rpc.rusersd/rusers_proc.c

Loading...

libexec/rpc.rusersd/rusersd.c

Loading...

libexec/rpc.sprayd/sprayd.c

Loading...

libexec/rtld-elf/rtld_malloc.c

Loading...

libexec/talkd/announce.c

Loading...

libexec/talkd/print.c

Loading...

libexec/talkd/process.c

Loading...

libexec/talkd/table.c

Loading...

libexec/talkd/talkd.c

Loading...

sbin/dump/dumprmt.c

Loading...

sbin/dump/itime.c

Loading...

sbin/dump/main.c

Loading...

sbin/dump/optr.c

Loading...

sbin/dump/tape.c

Loading...

sbin/dump/traverse.c

Loading...

sbin/dump/unctime.c

Loading...

sbin/dumpfs/dumpfs.c

Loading...

sbin/ffsinfo/ffsinfo.c

Loading...

sbin/fsck_msdosfs/boot.c

Loading...

sbin/fsck_msdosfs/check.c

Loading...

sbin/fsck_msdosfs/dir.c

Loading...

sbin/fsck_msdosfs/fat.c

Loading...

sbin/fsck_msdosfs/main.c

Loading...

sbin/fsdb/fsdb.c

Loading...

sbin/fsdb/fsdbutil.c

Loading...

sbin/fsirand/fsirand.c

Loading...

sbin/growfs/debug.c

Loading...

sbin/ifconfig/af_inet.c

Loading...

sbin/ifconfig/af_inet6.c

Loading...

sbin/ifconfig/af_link.c

Loading...

sbin/ifconfig/af_nd6.c

Loading...

sbin/ifconfig/ifbridge.c

Loading...

sbin/ifconfig/ifclone.c

Loading...

sbin/ifconfig/ifconfig.c

Loading...

sbin/ifconfig/ifgif.c

Loading...

sbin/ifconfig/ifgroup.c

Loading...

sbin/ifconfig/iflagg.c

Loading...

sbin/ifconfig/ifvlan.c

Loading...

sbin/ifconfig/sfp.c

Loading...

sbin/init/init.c

Loading...

sbin/mknod/mknod.c

Loading...

sbin/mount/mount_fs.c

Loading...

sbin/mount_cd9660/mount_cd9660.c

Loading...

sbin/mount_msdosfs/mount_msdosfs.c

Loading...

sbin/mount_nullfs/mount_nullfs.c

Loading...

sbin/mount_unionfs/mount_unionfs.c

Loading...

sbin/newfs_msdos/mkfs_msdos.c

Loading...

sbin/newfs_msdos/newfs_msdos.c

Loading...

sbin/nos-tun/nos-tun.c

Loading...

sbin/restore/dirs.c

Loading...

sbin/restore/symtab.c

Loading...

sbin/restore/utilities.c

Loading...

sbin/umount/umount.c

Loading...

stand/libsa/powerpc/syncicache.c

Loading...

sys/netpfil/ipfilter/netinet/fil.c

Loading...

sys/netpfil/ipfilter/netinet/ip_auth.c

Loading...

sys/netpfil/ipfilter/netinet/ip_frag.c

Loading...

sys/netpfil/ipfilter/netinet/ip_nat.c

Loading...

usr.bin/locate/locate/locate.c

Loading...

usr.bin/mktemp/mktemp.c

Loading...

usr.bin/morse/morse.c

Loading...

usr.bin/nfsstat/nfsstat.c

Loading...

usr.bin/number/number.c

Loading...

usr.bin/primes/pattern.c

Loading...

usr.bin/primes/pr_tbl.c

Loading...

usr.bin/primes/primes.c

Loading...

usr.bin/printf/printf.c

Loading...

usr.bin/showmount/showmount.c

Loading...

usr.bin/tee/tee.c

Loading...

usr.bin/time/time.c

Loading...

usr.bin/truncate/truncate.c

Loading...

usr.bin/ul/ul.c

Loading...

usr.bin/uniq/uniq.c

Loading...

usr.bin/units/units.c

Loading...

usr.bin/yes/yes.c

Loading...

usr.sbin/apmd/apmd.c

Loading...

usr.sbin/btxld/btxld.c

Loading...

usr.sbin/ckdist/ckdist.c

Loading...

usr.sbin/config/main.cc

Loading...

usr.sbin/config/mkheaders.c

Loading...

usr.sbin/config/mkmakefile.cc

Loading...

usr.sbin/config/mkoptions.cc

Loading...

usr.sbin/flowctl/flowctl.c

Loading...

usr.sbin/keyserv/crypt_server.c

Loading...

usr.sbin/keyserv/keyserv.c

Loading...

usr.sbin/keyserv/setkey.c

Loading...

usr.sbin/mptable/mptable.c

Loading...

usr.sbin/nfsd/nfsd.c

Loading...

usr.sbin/pciconf/cap.c

Loading...

usr.sbin/pciconf/err.c

Loading...

usr.sbin/pciconf/pciconf.c

Loading...

usr.sbin/pw/bitmap.c

Loading...

usr.sbin/pw/cpdir.c

Loading...

usr.sbin/pw/grupd.c

Loading...

usr.sbin/pw/psdate.c

Loading...

usr.sbin/pw/pw.c

Loading...

usr.sbin/pw/pw_conf.c

Loading...

usr.sbin/pw/pw_group.c

Loading...

usr.sbin/pw/pw_log.c

Loading...

usr.sbin/pw/pw_nis.c

Loading...

usr.sbin/pw/pw_user.c

Loading...

usr.sbin/pw/pw_vpw.c

Loading...

usr.sbin/pw/pwupd.c

Loading...

usr.sbin/pw/rm_r.c

Loading...

usr.sbin/rpc.lockd/test.c

Loading...

usr.sbin/rpc.statd/test.c

Loading...

usr.sbin/rpc.umntall/rpc.umntall.c

Loading...

usr.sbin/rpc.ypupdated/update.c

Loading...

usr.sbin/spray/spray.c

Loading...

usr.sbin/traceroute6/traceroute6.c

Loading...

usr.sbin/vidcontrol/decode.c

Loading...

usr.sbin/vidcontrol/vidcontrol.c

Loading...