PR: 266627
Details
Details
- Reviewers
se jilles pauamma_gundo.com - Group Reviewers
manpages - Commits
- rGa7eac018437e: stty(1): provide details about interaction with job control
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| bin/stty/stty.1 | ||
|---|---|---|
| 104 | "not prepared to handle it" or "not prepared for it" | |
Comment Actions
Since a similar effect can be obtained by having the shell ignore the signal via trap '' TTOU, I'm not sure it's a good idea to add an option for this.
An addition to the man page may be a good idea, though, since this effect of the disposition of SIGTTOU is listed in tcsetattr(3) but not in section 1 man pages.
| bin/stty/stty.c | ||
|---|---|---|
| 74–75 | Because various operands to stty start with - and do not need --, every option added makes it more likely to get a conflict between an option and an operand. This suggests only adding options when it is extremely important, and perhaps using uppercase for options to make conflicts less likely. | |
| bin/stty/stty.1 | ||
|---|---|---|
| 628 | It is open(2) O_NONBLOCK. It is mentioned earlier in the man page, in the description of -f. | |
Comment Actions
One minor manual page nit, fixable on commit.
| bin/stty/stty.1 | ||
|---|---|---|
| 630 | Should be above the .Pp. | |
| bin/stty/stty.1 | ||
|---|---|---|
| 630 | Should be .Nm | |