Differential D56185

pmap: Do not use PMAP_LOCK_INIT with kernel_pmap
ClosedPublic
Actions

Authored by markj on Tue, Mar 31, 3:16 PM.

Tags

None

Referenced Files

	F154262606: D56185.id175164.diff
	Mon, Apr 27, 11:33 AM

	F154251799: D56185.id.diff
	Mon, Apr 27, 10:09 AM

	Unknown Object (File)
	Sun, Apr 19, 10:16 AM

	Unknown Object (File)
	Sat, Apr 18, 9:46 PM

	Unknown Object (File)
	Sat, Apr 18, 2:00 PM

	Unknown Object (File)
	Sat, Apr 18, 11:39 AM

	Unknown Object (File)
	Sat, Apr 18, 3:45 AM

	Unknown Object (File)
	Sat, Apr 18, 3:45 AM

View All 21 Files

Subscribers

Details

Reviewers

alc
kib
andrew
manu

Commits

rG90fc3831af15: pmap: Do not use PMAP_LOCK_INIT with kernel_pmap
rGc6a1c1260f02: pmap: Do not use PMAP_LOCK_INIT with kernel_pmap

Summary

The kernel_pmap lock is a bit special: it does not need the DUPOK flag,
and it really belongs to a different lock class. If it belongs to the
same class as regular pmap locks, than witness may report warnings when
performing UMA allocations under a regular pmap lock, if the allocation
triggers a pmap_growkernel() call.

Replace instances of PMAP_LOCK_INIT(kernel_pmap) with inline mtx_init()
calls to silence some witness warnings I see with some uncommitted test
programs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Tue, Mar 31, 3:16 PM

Herald added a reviewer: andrew. · View Herald TranscriptTue, Mar 31, 3:16 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: riscv, jhibbits, emaste, imp. · View Herald Transcript

markj requested review of this revision.Tue, Mar 31, 3:16 PM

Harbormaster completed remote builds in B71862: Diff 174641.Tue, Mar 31, 3:16 PM

"... pmap locks, than witness ..." -> "... pmap locks, then witness ..."

This revision is now accepted and ready to land.Tue, Mar 31, 3:20 PM

kib accepted this revision.Wed, Apr 1, 2:09 AM

Closed by commit rGc6a1c1260f02: pmap: Do not use PMAP_LOCK_INIT with kernel_pmap (authored by markj). · Explain WhyThu, Apr 9, 1:45 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc6a1c1260f02: pmap: Do not use PMAP_LOCK_INIT with kernel_pmap.

markj added a commit: rG90fc3831af15: pmap: Do not use PMAP_LOCK_INIT with kernel_pmap.Sat, Apr 18, 10:35 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

2 lines

arm/

arm/

2 lines

arm64/

arm64/

2 lines

i386/

i386/

2 lines

powerpc/

aim/

2 lines

2 lines

2 lines

booke/

2 lines

riscv/

riscv/

2 lines

Diff 175164

sys/amd64/amd64/pmap.c

Loading...

sys/arm/arm/pmap-v6.c

Loading...

sys/arm64/arm64/pmap.c

Loading...

sys/i386/i386/pmap.c

Loading...

sys/powerpc/aim/mmu_oea.c

Loading...

sys/powerpc/aim/mmu_oea64.c

Loading...

sys/powerpc/aim/mmu_radix.c

Loading...

sys/powerpc/booke/pmap.c

Loading...

sys/riscv/riscv/pmap.c

Loading...