Page MenuHomeFreeBSD

pmap: Do not use PMAP_LOCK_INIT with kernel_pmap
AcceptedPublic

Authored by markj on Tue, Mar 31, 3:16 PM.

Details

Reviewers
alc
kib
andrew
manu
Summary

The kernel_pmap lock is a bit special: it does not need the DUPOK flag,
and it really belongs to a different lock class. If it belongs to the
same class as regular pmap locks, than witness may report warnings when
performing UMA allocations under a regular pmap lock, if the allocation
triggers a pmap_growkernel() call.

Replace instances of PMAP_LOCK_INIT(kernel_pmap) with inline mtx_init()
calls to silence some witness warnings I see with some uncommitted test
programs.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71862
Build 68745: arc lint + arc unit

Event Timeline

markj requested review of this revision.Tue, Mar 31, 3:16 PM

"... pmap locks, than witness ..." -> "... pmap locks, then witness ..."

This revision is now accepted and ready to land.Tue, Mar 31, 3:20 PM