Paths

Table of Contentst

Differential D55949

arm64: Support changing the DMAP memory type
Needs ReviewPublic
Actions

Authored by andrew on Mar 19 2026, 4:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 19, 8:52 PM

	Unknown Object (File)
	Sun, Apr 19, 8:52 PM

	Unknown Object (File)
	Sat, Apr 18, 1:25 PM

	Unknown Object (File)
	Sat, Apr 18, 6:07 AM

	Unknown Object (File)
	Mon, Apr 13, 3:42 PM

	Unknown Object (File)
	Sun, Apr 12, 1:00 AM

	Unknown Object (File)
	Sat, Apr 11, 10:30 AM

	Unknown Object (File)
	Sat, Apr 11, 10:13 AM

View All 19 Files

Subscribers

Details

Reviewers

manu
alc
kib
markj

Group Reviewers

Summary

When MTE is enabled we will use the DMAP to manage tags. To be able to
read/write them we need to change the memory attribute to
VM_MEMATTR_TAGGED.

Support changing the DMAP memory type to values known to have
equivalent cache properties.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72176
Build 69059: arc lint + arc unit

Event Timeline

andrew created this revision.Mar 19 2026, 4:05 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 19 2026, 4:05 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Mar 19 2026, 4:05 PM

Harbormaster completed remote builds in B71530: Diff 173919.Mar 19 2026, 4:05 PM

andrew added a parent revision: D55948: arm64: mte: add tagged memory attribute.Mar 19 2026, 4:05 PM

andrew added a child revision: D55950: arm64: Support some per-thread sctlr_el1 fields.

andrew added reviewers: alc, kib, markj.Mar 19 2026, 4:25 PM

markj added inline comments.Mar 23 2026, 2:10 AM

sys/arm64/arm64/pmap.c
8326–8330	Please update this comment.
8464	Can the comment please explain why this is necessary?
8477	Suppose we update a range with `mode == VM_MEMATTR_WRITE_BACK`, and `dmap_attr != VM_MEMATTR_WRITE_BACK`. Then, a subsequent update of the same range with `old_mode == VM_MEMATTR_WRITE_BACK` will not update the DMAP entries, which seems like a bug.

andrew added inline comments.Mon, Apr 13, 2:13 PM

sys/arm64/arm64/pmap.c
8477	The only way we can currently get here with `old_mode != -1` is through `pmap_change_dmap_attr` so will have `old_mode == dmap_attr` so the memory will be updated. If we find other uses for `old_mode` then we may need to be smarter about handling `old_mode` for DMAP regions.

Update comments

Harbormaster completed remote builds in B72176: Diff 175435.Mon, Apr 13, 2:26 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

64 lines

include/

1 line

Diff 175435

sys/arm64/arm64/pmap.c

Loading...

sys/arm64/include/pmap.h

Loading...