Paths

Table of Contentst

Differential D36200

da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC
ClosedPublic
Actions

Authored by jrtc27 on Aug 14 2022, 5:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 12, 9:35 PM

	Unknown Object (File)
	Sat, Sep 12, 12:49 AM

	Unknown Object (File)
	Sun, Sep 6, 2:25 AM

	Unknown Object (File)
	Sun, Sep 6, 2:19 AM

	Unknown Object (File)
	Sat, Sep 5, 5:28 AM

	Unknown Object (File)
	Sat, Sep 5, 5:03 AM

	Unknown Object (File)
	Sat, Sep 5, 4:17 AM

	Unknown Object (File)
	Sat, Sep 5, 1:47 AM

Subscribers

Details

Reviewers

manu
mhorne
imp

Commits

rGc31ecc099dcd: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC
rG129028c79c6c: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC

Summary

This is a simple RTC present in the PMIC, supporting 1s precision.

This is the PMIC on SiFive's HiFive Unmatched.

MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47059
Build 43948: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Aug 14 2022, 5:33 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 14 2022, 5:33 PM

jrtc27 requested review of this revision.Aug 14 2022, 5:33 PM

Harbormaster completed remote builds in B46939: Diff 109335.Aug 14 2022, 5:33 PM

jrtc27 added a parent revision: D36199: da9063_iic: Add new driver for the Dialog Semiconductor DA9063 PMIC.Aug 14 2022, 5:34 PM

jrtc27 added a child revision: D36201: riscv: Add da9063_pmic and da9063_rtc to GENERIC and NOTES.

Add missing utc_offset call for the local time RTC case

Harbormaster completed remote builds in B46941: Diff 109337.Aug 14 2022, 5:56 PM

No clue of the talking to the hardware part is right, but I believe the time handling is now correct.

This revision is now accepted and ready to land.Aug 15 2022, 7:50 PM

mhorne added inline comments.Aug 18 2022, 9:27 PM

sys/dev/dialog/da9063/da9063_rtc.c
171–173	Isn't `ct.min != oldct.min` the only check that matters here?

jrtc27 added inline comments.Aug 18 2022, 9:29 PM

sys/dev/dialog/da9063/da9063_rtc.c
171–173	In practice yes, but technically you could, say, get preempted for an {hour,day,month,year} (which in reality would only ever happen if using a debugger and you got unlucky) so {min, hour,day,mon,year} would fully wrap around, and it felt wrong to be lazy.

Renamed da9063 to da9063_pmic

This revision now requires review to proceed.Aug 22 2022, 7:27 PM

Harbormaster completed remote builds in B47059: Diff 109682.Aug 22 2022, 7:27 PM

jrtc27 edited the summary of this revision. (Show Details)Aug 22 2022, 7:28 PM

imp accepted this revision.Aug 22 2022, 10:02 PM

This revision is now accepted and ready to land.Aug 22 2022, 10:02 PM

mhorne accepted this revision.Sep 13 2022, 4:43 PM

Closed by commit rG129028c79c6c: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC (authored by jrtc27). · Explain WhySep 13 2022, 4:47 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG129028c79c6c: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.

jrtc27 added a commit: rGc31ecc099dcd: da9063_rtc: Add new driver for the Dialog Semiconductor DA9063 RTC.Aug 1 2023, 9:07 PM

Revision Contents
Changeset List

Path

Size

sys/

conf/

1 line

dev/

dialog/

da9063/

293 lines

Diff 109682

sys/conf/files

Loading...

sys/dev/dialog/da9063/da9063_rtc.c

Loading...