Page MenuHomeFreeBSD
Differential D33761

libsoft: Remove
ClosedPublic
Actions

Authored by imp on Jan 5 2022, 11:56 PM.
Tags
None
Referenced Files
F153982558: D33761.id101080.diff
Sat, Apr 25, 6:16 AM
Unknown Object (File)
Fri, Apr 17, 6:57 PM
Unknown Object (File)
Fri, Apr 17, 9:35 AM
Unknown Object (File)
Thu, Apr 9, 6:13 AM
Unknown Object (File)
Thu, Apr 9, 1:23 AM
Unknown Object (File)
Wed, Apr 8, 5:25 AM
Unknown Object (File)
Wed, Apr 8, 4:35 AM
Unknown Object (File)
Wed, Apr 8, 4:20 AM
View All Files
Subscribers
andrew
bdragon
bdrewery
emaste
manu
mmel
stevek
wma

Details

Reviewers
arichardson
jrtc27
brooks
jhb
mmel
manu
Group Reviewers
ARM
Commits
rGf84135f69999: libsoft: Remove
Summary

libsoft was a transition from the FreeBSD/armv6 10 (and earlier) with
'softfp' ABI (that is, hardware float, but passed as integer registers)
to the 'hardfp' ABI that was in FreeBSD/armv[67] in FreeBSD 11 and
newer. It's been off by default for a while. It's time to retire it.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43731
Build 40619: arc lint + arc unit

Event Timeline

imp created this revision.Jan 5 2022, 11:56 PM
Herald added subscribers: bdragon, emaste, andrew, bdrewery. · View Herald TranscriptJan 5 2022, 11:56 PM
imp requested review of this revision.Jan 5 2022, 11:56 PM
Harbormaster completed remote builds in B43731: Diff 101025.Jan 5 2022, 11:57 PM
imp added reviewers: arichardson, jrtc27, brooks, jhb, ARM.Jan 5 2022, 11:57 PM
brooks added a comment.Jan 6 2022, 12:51 AM

Does there need to be a set of ObsoleteFiles entries?

share/mk/bsd.compat.mk
119
imp added a comment.Jan 6 2022, 6:19 AM
In D33761#763453, @brooks wrote:

Does there need to be a set of ObsoleteFiles entries?

I don't think so. It's not in the tools/build/mk/OptionalObsoleteFiles.inc file today
and is obscure enough to not bother. And generating the list would be a huge pain.

imp updated this revision to Diff 101033.Jan 6 2022, 6:20 AM

review

Harbormaster completed remote builds in B43737: Diff 101033.Jan 6 2022, 6:20 AM
mmel accepted this revision.Jan 6 2022, 7:31 AM
mmel added a subscriber: mmel.

LGTM

This revision is now accepted and ready to land.Jan 6 2022, 7:31 AM
manu accepted this revision.Jan 6 2022, 10:44 AM
manu added subscribers: wma, stevek, manu.

LGTM

Maybe wait for @stevek or @wma as IIRC one of them used it for some platform but I could be wrong.

jhb added inline comments.Jan 6 2022, 5:21 PM
share/mk/bsd.compat.mk
119

Judging by the comment I do think this might be a GCC-only thing. I think it was originally a libsoft-only thing I had added it for lib32 for mips. I think clang finds /usr/lib32 in the sysroot automatically if it is present.

jrtc27 added inline comments.Jan 6 2022, 6:36 PM
libexec/rc/rc.conf
660

This got missed

stevek added a comment.Jan 6 2022, 8:37 PM
In D33761#763599, @manu wrote:

LGTM

Maybe wait for @stevek or @wma as IIRC one of them used it for some platform but I could be wrong.

We use soft float on our products, but we have never used the LIBSOFT functionality.

manu added a comment.Jan 6 2022, 10:34 PM
In D33761#763783, @stevek wrote:
In D33761#763599, @manu wrote:

LGTM

Maybe wait for @stevek or @wma as IIRC one of them used it for some platform but I could be wrong.

We use soft float on our products, but we have never used the LIBSOFT functionality.

Ok thanks, I new I remember something about soft something from you, just wasn't sure what it was :)

imp updated this revision to Diff 101080.Jan 7 2022, 5:11 AM

Remove some more localsoft stuff

This revision now requires review to proceed.Jan 7 2022, 5:11 AM
Harbormaster completed remote builds in B43757: Diff 101080.Jan 7 2022, 5:11 AM
imp marked an inline comment as done.Jan 7 2022, 5:16 AM
imp added inline comments.
libexec/rc/rc.conf
660

As did code in ldconfigure script. Thanks

imp marked an inline comment as done.Jan 7 2022, 5:17 AM
In D33761#763827, @manu wrote:
In D33761#763783, @stevek wrote:
In D33761#763599, @manu wrote:

LGTM

Maybe wait for @stevek or @wma as IIRC one of them used it for some platform but I could be wrong.

We use soft float on our products, but we have never used the LIBSOFT functionality.

Ok thanks, I new I remember something about soft something from you, just wasn't sure what it was :)

Yea, that was my memory. Actual soft floating implementation, not this weird thing :) I'll take that as a go ahead on removing this then.

I plan on breaking this up into a few commits before pushing it in. This one kinda got away from me while in process.

imp updated this revision to Diff 101083.Jan 7 2022, 5:25 AM

jhb says this is just for gcc since clang has lib32 in its path with -m32.

Harbormaster completed remote builds in B43760: Diff 101083.Jan 7 2022, 5:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2022, 5:47 AM
Closed by commit rGf84135f69999: libsoft: Remove (authored by imp). · Explain Why
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGf84135f69999: libsoft: Remove.

Revision Contents
Changeset List

PathSize
4 lines
3 lines
etc/
4 lines
mtree/
4 lines
libexec/
rc/
3 lines
rtld-elf/
arm/
40 lines
6 lines
6 lines
share/
mk/
15 lines
5 lines

Diff 101025

View Options

Makefile

Loading...
View Options

Makefile.inc1

Loading...
View Options

etc/Makefile

Loading...
View Options

etc/mtree/BSD.libsoft.dist

Loading...
View Options

etc/mtree/Makefile

Loading...
View Options

libexec/rc/rc.conf

Loading...
View Options

libexec/rtld-elf/arm/reloc.c

Loading...
View Options

libexec/rtld-elf/arm/rtld_machdep.h

Loading...
View Options

libexec/rtld-elf/rtld_paths.h

Loading...
View Options

share/mk/bsd.compat.mk

Loading...
View Options

share/mk/src.opts.mk

Loading...