Differential D33607

OCF: Add crypto_clonereq().
ClosedPublic
Actions

Authored by jhb on Dec 21 2021, 9:39 PM.

Details

Reviewers

markj

Group Reviewers

manpages

Commits

rG6a13905b5ab3: OCF: Add crypto_clonereq().
rG74d3f1b63dbe: OCF: Add crypto_clonereq().

Summary

This function clones an existing crypto request, but associates the
new request with a specified session. The intended use case is for
drivers to be able to fall back to software by cloning a request and
dispatch it to an internally allocated software session.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Dec 21 2021, 9:39 PM

Herald added a reviewer: manpages. · View Herald TranscriptDec 21 2021, 9:39 PM

Herald added subscribers: jmg, imp. · View Herald Transcript

jhb requested review of this revision.Dec 21 2021, 9:39 PM

Harbormaster completed remote builds in B43530: Diff 100433.Dec 21 2021, 9:39 PM

jhb added a child revision: D33608: ccr: Use a software OCF session for requests which fallback to software..Dec 21 2021, 9:40 PM

pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.Dec 26 2021, 1:53 AM

pauamma_chezdork.com added inline comments.

share/man/man9/crypto_request.9
84	For readability, but may be personal taste.
106	As above.

markj accepted this revision.Dec 26 2021, 11:11 PM

markj added inline comments.

share/man/man9/crypto_request.9
84	+1
sys/opencrypto/cryptodev.h
432	I'm not sure it makes sense to inherit CRYPTO_F_DONE given that the callback is not copied.

This revision is now accepted and ready to land.Dec 26 2021, 11:11 PM

jhb added inline comments.Dec 29 2021, 11:21 PM

sys/opencrypto/cryptodev.h
432	That is true, but in the intended use cases it should never be set. It may arguably be a bug (and worth asserting on?) if the flag is set in the source request? I can't think of any use cases where you want to clone a competed request. If the request failed with an error and you want to retry it (and maybe clone it as part of retrying), then I think you would want to clear DONE before doing the clone for example.