Page MenuHomeFreeBSD

m4: Convert tests to ATF
ClosedPublic

Authored by des on Feb 4 2026, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 7, 11:58 AM
Unknown Object (File)
Sun, Mar 1, 3:04 AM
Unknown Object (File)
Mon, Feb 23, 9:57 PM
Unknown Object (File)
Wed, Feb 18, 12:53 PM
Unknown Object (File)
Wed, Feb 18, 12:53 PM
Unknown Object (File)
Wed, Feb 18, 11:36 AM
Unknown Object (File)
Wed, Feb 18, 11:35 AM
Unknown Object (File)
Wed, Feb 18, 10:57 AM
Subscribers

Details

Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Feb 4 2026, 8:53 PM

kind of dirty, but ig you could have another function for generating these testcases using eval:

define_test()
{
	name=$1
	shift
	args=$*

	eval "
${name}_head()
{
}
${name}_body()
{
	m4_test ${args} ${name}
}
"
}

# [...]

define_test eval
define_test ff_after_dnl
define_test gnueval -g
define_test gnuformat -g

# [...]
usr.bin/m4/tests/m4_test.sh
71

presumably?

kind of dirty, but ig you could have another function for generating these testcases using eval:

I did that for sbin/md5 and regretted it.

des marked an inline comment as done.Feb 5 2026, 1:49 PM

It looks fine to me...

This revision is now accepted and ready to land.Feb 7 2026, 6:07 PM
This revision was automatically updated to reflect the committed changes.