Page MenuHomeFreeBSD
Differential D50328

bridge(4): default net.link.bridge.member_ifaddrs to false
ClosedPublic
Actions

Authored by ivy on Tue, May 13, 2:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 2, 8:35 PM
Unknown Object (File)
Sun, Jun 1, 4:26 AM
Unknown Object (File)
Mon, May 19, 11:20 AM
Unknown Object (File)
Mon, May 19, 3:48 AM
Unknown Object (File)
Mon, May 19, 3:46 AM
Unknown Object (File)
Sun, May 18, 11:36 AM
Unknown Object (File)
Sun, May 18, 9:08 AM
Unknown Object (File)
Sat, May 17, 9:03 PM
View All 9 Files
Subscribers
ae
glebius
imp
kp
melifaro
ziaee

Details

Reviewers
des
kevans
kp
Group Reviewers
network
manpages
Commits
rGb61850c4e6f6: bridge(4): default net.link.bridge.member_ifaddrs to false
Summary

as discussed on arch@, this behaviour is broken and confuses users, so
disable it by default. for 15.0-RELEASE, allow it to be re-enabled
using a sysctl, but the sysctl will be removed in 16.0R.

Relnotes: yes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Tue, May 13, 2:32 PM
Herald added subscribers: ziaee, glebius, melifaro and 2 others. · View Herald TranscriptTue, May 13, 2:32 PM
ivy requested review of this revision.Tue, May 13, 2:32 PM
Harbormaster completed remote builds in B64135: Diff 155392.Tue, May 13, 2:32 PM
ivy added a child revision: D50329: RELNOTES: document bridge(4) member_ifaddrs change.Tue, May 13, 2:33 PM
ivy added a reviewer: network.Tue, May 13, 2:33 PM
ivy added a reviewer: manpages.Tue, May 13, 2:36 PM
ivy updated this revision to Diff 155396.Tue, May 13, 2:47 PM

also initialise the variable to false

Harbormaster completed remote builds in B64139: Diff 155396.Tue, May 13, 2:47 PM
kp accepted this revision as: kp.Tue, May 13, 8:33 PM
kp added a subscriber: kp.

It'll want an entry in UPDATING too. I have no strong views about doing this in this commit or a subsequent one.

This revision is now accepted and ready to land.Tue, May 13, 8:33 PM
ivy updated this revision to Diff 155416.Tue, May 13, 9:30 PM

add an UPDATING entry

This revision now requires review to proceed.Tue, May 13, 9:30 PM
Harbormaster completed remote builds in B64151: Diff 155416.Tue, May 13, 9:31 PM
des accepted this revision.Wed, May 14, 10:31 AM
This revision is now accepted and ready to land.Wed, May 14, 10:31 AM
Closed by commit rGb61850c4e6f6: bridge(4): default net.link.bridge.member_ifaddrs to false (authored by ivy). · Explain WhyThu, May 15, 12:04 AM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rGb61850c4e6f6: bridge(4): default net.link.bridge.member_ifaddrs to false.

Revision Contents
Changeset List

PathSize
5 lines
share/
man/
man4/
18 lines
sys/
net/
4 lines

Diff 155480

View Options

UPDATING

Loading...
View Options

share/man/man4/bridge.4

Loading...
View Options

sys/net/if_bridge.c

Loading...