uart/ns8250: Factor out reading the divisor
ClosedPublic
Actions

Authored by imp on Oct 11 2024, 9:53 PM.

Tags

None

Referenced Files

	F168395087: D47074.id144678.diff
	Fri, Aug 28, 12:16 AM

	Unknown Object (File)
	Fri, Aug 14, 10:01 AM

	Unknown Object (File)
	Fri, Aug 14, 2:10 AM

	Unknown Object (File)
	Fri, Aug 14, 12:23 AM

	Unknown Object (File)
	Tue, Aug 11, 12:58 AM

	Unknown Object (File)
	Mon, Aug 10, 10:14 PM

	Unknown Object (File)
	Mon, Aug 10, 5:49 PM

	Unknown Object (File)
	Mon, Aug 10, 2:07 PM

View All Files

Subscribers

None

Details

Reviewers

markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel

Commits

rG4097cd06ca49: uart/ns8250: Factor out reading the divisor

Summary

We have two copies (soon to be three) of reading the divisor. Since it's
a complicated tricky process, abstract it to its own routine.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 11 2024, 9:53 PM

imp created this revision.

Harbormaster completed remote builds in B59921: Diff 144678.Oct 11 2024, 9:53 PM

imp added a parent revision: D47073: uart/ns8250: Tweak printfs to always prefix messages with uart:.Oct 11 2024, 9:53 PM

imp added a child revision: D47075: uart/ns8250: Disable interrupts sooner.

markj accepted this revision.Oct 12 2024, 2:52 PM

This revision is now accepted and ready to land.Oct 12 2024, 2:52 PM

andrew accepted this revision.Oct 14 2024, 9:28 AM

Closed by commit rG4097cd06ca49: uart/ns8250: Factor out reading the divisor (authored by imp). · Explain WhyOct 14 2024, 10:18 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG4097cd06ca49: uart/ns8250: Factor out reading the divisor.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_dev_ns8250.c

27 lines

Diff 144858

View Options

sys/dev/uart/uart_dev_ns8250.c

uart/ns8250: Factor out reading the divisorClosedPublicActions