Page MenuHomeFreeBSD
Differential D47080

acpidump: Document the alphabit soup of ACPI Table names
ClosedPublic
Actions

Authored by imp on Oct 11 2024, 9:54 PM.
Tags
None
Referenced Files
F132489441: D47080.diff
Fri, Oct 17, 8:40 AM
F132460951: D47080.id144886.diff
Fri, Oct 17, 3:15 AM
Unknown Object (File)
Mon, Oct 6, 11:17 PM
Unknown Object (File)
Sat, Sep 20, 11:53 AM
Unknown Object (File)
Thu, Sep 18, 10:46 AM
Unknown Object (File)
Sep 2 2025, 8:42 PM
Unknown Object (File)
Sep 2 2025, 8:30 AM
Unknown Object (File)
Sep 1 2025, 12:28 AM
View All 77 Files
Subscribers
None

Details

Reviewers
markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel
Commits
rGbbfd734823f4: acpidump: Document the alphabit soup of ACPI Table names
Summary

Clarify what's reported with -t (it's all the fixed acpi tables,
not just the listed ones). The listed tables are more fully decoded,
while all other tables just have their headers decoded.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 11 2024, 9:54 PM
imp created this revision.
Harbormaster completed remote builds in B59927: Diff 144684.Oct 11 2024, 9:54 PM
imp added a parent revision: D47079: acpidump: Move to acpi.rsdp.Oct 11 2024, 9:54 PM
imp added a child revision: D47081: acpidump: Sort signature ifs alphabetically and make table driven.
markj added inline comments.Oct 12 2024, 2:57 PM
usr.sbin/acpi/acpidump/acpidump.8
104
107
119

Missing a description here.

123
139–157
imp updated this revision to Diff 144792.Oct 13 2024, 10:32 PM

update per markj's review

Harbormaster completed remote builds in B59964: Diff 144792.Oct 13 2024, 10:32 PM
adrian accepted this revision.Oct 13 2024, 10:43 PM

nice work! approved (after markj's comments)

This revision is now accepted and ready to land.Oct 13 2024, 10:43 PM
imp edited parent revisions, added: D47109: acpidump: Use ACPI_NAMESEG_SIZE instead of 4; removed: D47079: acpidump: Move to acpi.rsdp.Oct 14 2024, 4:33 PM
Closed by commit rGbbfd734823f4: acpidump: Document the alphabit soup of ACPI Table names (authored by imp). · Explain WhyOct 15 2024, 11:14 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGbbfd734823f4: acpidump: Document the alphabit soup of ACPI Table names.

Revision Contents
Changeset List

PathSize
usr.sbin/
acpi/
acpidump/
91 lines

Diff 144886

View Options

usr.sbin/acpi/acpidump/acpidump.8

Loading...