Paths

Table of Contentst

Differential D47077

uart/pl011: Add support for computing rclk
ClosedPublic
Actions

Authored by imp on Oct 11 2024, 9:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 3, 7:41 AM

	Unknown Object (File)
	Fri, Dec 27, 9:56 PM

	Unknown Object (File)
	Wed, Dec 25, 11:14 AM

	Unknown Object (File)
	Tue, Dec 17, 10:10 AM

	Unknown Object (File)
	Tue, Dec 17, 3:22 AM

	Unknown Object (File)
	Dec 5 2024, 7:03 PM

	Unknown Object (File)
	Nov 24 2024, 3:30 AM

	Unknown Object (File)
	Nov 24 2024, 3:02 AM

View All 30 Files

Subscribers

None

Details

Reviewers

markj
andrew
adrian
jhb
jrtc27
bz
marius
oh
manu
kevans
cperciva
mhorne
mw
mmel

Commits

rG28ce46d8625d: uart/pl011: Add support for computing rclk

Summary

When instructed to do so, compute the rclk (baud rate generator clock)
based on the currently programmed divisor and the communicated baud
rate. We only do this once and only for consoles that tell us the
configured rate and flag we can likely safely compute rclk.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Oct 11 2024, 9:54 PM

imp created this revision.

Harbormaster completed remote builds in B59924: Diff 144681.Oct 11 2024, 9:54 PM

imp added a parent revision: D47076: uart/ns8250: Add support for computing rclk.Oct 11 2024, 9:54 PM

imp added a child revision: D47078: uart: uart_getenv: check for NULL class last, not first.

andrew added inline comments.Oct 14 2024, 11:43 AM

sys/dev/uart/uart_dev_pl011.c
247	Why `& ~3`?

Update to use proper constants for this computation. Don't know what I was
thinking before.

Harbormaster completed remote builds in B59980: Diff 144834.Oct 14 2024, 5:14 PM

andrew accepted this revision.Oct 15 2024, 8:12 AM

This revision is now accepted and ready to land.Oct 15 2024, 8:12 AM

Closed by commit rG28ce46d8625d: uart/pl011: Add support for computing rclk (authored by imp). · Explain WhyOct 15 2024, 11:01 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG28ce46d8625d: uart/pl011: Add support for computing rclk.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_dev_pl011.c

18 lines

Diff 144884

sys/dev/uart/uart_dev_pl011.c

Loading...