Page MenuHomeFreeBSD
Differential D41181

ObsoleteFiles.inc: Automatically generate OpenSSL 3 obsoleted libcompat dirs
ClosedPublic
Actions

Authored by jrtc27 on Jul 25 2023, 8:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 1:19 PM
Unknown Object (File)
Tue, Nov 19, 11:17 AM
Unknown Object (File)
Mon, Nov 18, 8:19 AM
Unknown Object (File)
Mon, Nov 18, 5:03 AM
Unknown Object (File)
Mon, Nov 18, 1:40 AM
Unknown Object (File)
Sat, Nov 9, 1:38 PM
Unknown Object (File)
Sat, Nov 9, 1:37 PM
Unknown Object (File)
Sat, Nov 9, 1:37 PM
View All 56 Files
Subscribers
None

Details

Reviewers
brooks
jhb
emaste
imp
Commits
rG5e2bc2f60c8e: ObsoleteFiles.inc: Automatically generate OpenSSL 3 obsoleted libcompat dirs
Summary

Older entries in this file are left alone as hard-coding lib32 as
they're not worth the churn; downstreams will have already moved past
them (in particular, CheriBSD, which adds additional libcompats).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrtc27 requested review of this revision.Jul 25 2023, 8:00 PM
jrtc27 created this revision.
Harbormaster completed remote builds in B52829: Diff 125145.Jul 25 2023, 8:00 PM
emaste added inline comments.Jul 25 2023, 8:03 PM
ObsoleteFiles.inc
81–83

where does _ALL_libcompats come from?

jrtc27 added a parent revision: D41180: Makefile.inc1: Automatically generate _LIBCOMPATS and list-old-* libcompats.Jul 25 2023, 8:05 PM
jrtc27 added inline comments.
ObsoleteFiles.inc
81–83

See D41178 (its definition) and D41180 (making it available in Makefile.inc1); you were quicker than I could put all the reviews up and create the stack

emaste added inline comments.Jul 25 2023, 8:16 PM
ObsoleteFiles.inc
81–83

Yeah I realized that was likely the case once I looked at a 2nd review in this series and had a similar question.

brooks accepted this revision.Jul 25 2023, 9:29 PM
This revision is now accepted and ready to land.Jul 25 2023, 9:29 PM
emaste accepted this revision.Jul 25 2023, 10:38 PM
jhb accepted this revision.Jul 26 2023, 8:49 PM
Closed by commit rG5e2bc2f60c8e: ObsoleteFiles.inc: Automatically generate OpenSSL 3 obsoleted libcompat dirs (authored by jrtc27). · Explain WhyJul 27 2023, 4:13 AM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG5e2bc2f60c8e: ObsoleteFiles.inc: Automatically generate OpenSSL 3 obsoleted libcompat dirs.

Revision Contents
Changeset List

PathSize
4 lines

Diff 125229

View Options

ObsoleteFiles.inc

Loading...