Fix for use after free when detaching network interface
Needs ReviewPublic
Actions

Authored by hselasky on Wed, Jan 13, 2:57 PM.

Details

Reviewers

kevans
kib
kp
glebius
rgrimes

Summary

Implement API for draining slow paths in the network stack, like invocations
of if_ioctl(). This is needed to avoid use after free by user-space when a
network device detaches.

MFC after: 1 week
Sponsored by: Mellanox Technologies // NVIDIA Networking

Test Plan

Similar to D22691 .

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

hselasky created this revision.Wed, Jan 13, 2:57 PM

Herald added subscribers: melifaro, ae. · View Herald TranscriptWed, Jan 13, 2:57 PM

hselasky requested review of this revision.Wed, Jan 13, 2:57 PM

hselasky added inline comments.Wed, Jan 13, 3:00 PM

sys/net/if.c
771	We could set a bit in the "ifp" to prevent new slow_refs while draining. Right now that is not an issue.

Revision Contents
Changeset List

Path

Size

sys/

net/

if.c

46 lines

if_var.h

4 lines

Diff 82209

View Options

sys/net/if.c