Page MenuHomeFreeBSD

USBExperimental
ActivePublic

Details

Description

Groups related to USB stuff.

Recent Activity

Yesterday

aokblast added a comment to D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access..

Also, thanks for you patient and contribution. This patch makes some improvement for multiple devices case.

Sun, May 31, 1:55 PM · USB
aokblast added a comment to D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access..

Plus these point. Should we add O_CLOEXEC in here as libusb opened program can panic and thus flock never unlock

Sun, May 31, 1:51 PM · USB

Sat, May 30

adrian accepted D57089: apple_bce/vhci: add T2 virtual USB host controller.
Sat, May 30, 1:39 AM · USB, drivers, apple (x86)
adrian added a project to D57089: apple_bce/vhci: add T2 virtual USB host controller: USB.
Sat, May 30, 1:39 AM · USB, drivers, apple (x86)

Fri, May 29

aokblast added a reviewer for D57320: usb: Refactor functions need lock: adrian.
Fri, May 29, 7:07 AM · USB

Thu, May 28

aokblast closed D57293: usb: Add missing mtx lock and unlock in pushing dma queue.
Thu, May 28, 2:38 PM · USB
aokblast added a comment to D57293: usb: Add missing mtx lock and unlock in pushing dma queue.

nice catch! Why's this not panicing though? I thought I saw a lock assertion in usb_command_wrapper() ?

Thu, May 28, 2:31 PM · USB
adrian accepted D57293: usb: Add missing mtx lock and unlock in pushing dma queue.

nice catch! Why's this not panicing though? I thought I saw a lock assertion in usb_command_wrapper() ?

Thu, May 28, 2:29 PM · USB
aokblast updated the summary of D57293: usb: Add missing mtx lock and unlock in pushing dma queue.
Thu, May 28, 12:43 PM · USB
aokblast updated the diff for D57293: usb: Add missing mtx lock and unlock in pushing dma queue.

Refactor commit msg

Thu, May 28, 12:43 PM · USB
aokblast added reviewers for D57293: usb: Add missing mtx lock and unlock in pushing dma queue: adrian, USB.
Thu, May 28, 9:09 AM · USB

Tue, May 26

olce added a watcher for USB: olce.
Tue, May 26, 10:02 AM

Mon, May 25

aokblast added a comment to D57194: usb: Add SSP and SSPx2 speed and move USB_*_MAX into enum.
In D57194#1311193, @bz wrote:

Fantasic! You are solving one of my local TODOs :)

Can you make all these USB changes belonging together a stack in Phabricator?
It's a bit hard to grasp which all are there or belong together.
I'd be happy to at least scroll through them even if I cannot review them all in detail most likely.

% git show 9dbb804f59533d7d539200367394e4013714b02c
commit 9dbb804f59533d7d539200367394e4013714b02c
Author:     Bjoern A. Zeeb <bz@FreeBSD.org>
AuthorDate: Mon Feb 9 01:11:41 2026 +0000
Commit:     Bjoern A. Zeeb <bz@FreeBSD.org>
CommitDate: Sun May 24 15:53:58 2026 +0000

    TODO usb: add USB_SPEED_SUPER_PLUS to enum usb_dev_speed
    
    While nothing in our native USB stack uses the USB 3.1 "SUPERSPEED+"
    setting yet, a LinuxKPI based wireless driver does check for it.
    
    TODO: The arrays in usbd_get_std_packet_size() likely need to be updated.
    
    Sponsored by:   The FreeBSD Foundation
    MFC after:      3 days

diff --git sys/dev/usb/usb.h sys/dev/usb/usb.h
index 3e972f876c6a..f07eb9adfe40 100644
--- sys/dev/usb/usb.h
+++ sys/dev/usb/usb.h
@@ -755,8 +755,9 @@ enum usb_dev_speed {
        USB_SPEED_FULL,
        USB_SPEED_HIGH,
        USB_SPEED_SUPER,
+       USB_SPEED_SUPER_PLUS,
 };
-#define        USB_SPEED_MAX   (USB_SPEED_SUPER+1)
+#define        USB_SPEED_MAX   (USB_SPEED_SUPER_PLUS+1)
 
 /*
  * The "USB_REV" macros defines all the supported USB revisions.
Mon, May 25, 7:24 AM · USB
adrian added inline comments to D56970: usb: Refactor usb_proc_msg.
Mon, May 25, 2:51 AM · USB
adrian added a comment to D56970: usb: Refactor usb_proc_msg.

ugh yeah you're right, our mwait() implementation does the same thing and has the same issues, doesn't it? I've come to increasingly not like that; code really needs to treat exiting the mwait() as "all state may have changed", and it's not really suitable for serialising stuff like usb state / transfers.

Mon, May 25, 2:41 AM · USB

Sun, May 24

bz added a comment to D57194: usb: Add SSP and SSPx2 speed and move USB_*_MAX into enum.

Fantasic! You are solving one of my local TODOs :)

Sun, May 24, 11:05 PM · USB
aokblast added a comment to D56970: usb: Refactor usb_proc_msg.

So I'm starting to understand what you're trying to do here, however just a few things:

  • this code gets used or was used in some bootloader builds, right? So we need to make sure it runs in its standalone mode versus in the kernel
Sun, May 24, 4:19 PM · USB

Sat, May 23

adrian requested changes to D56970: usb: Refactor usb_proc_msg.

So I'm starting to understand what you're trying to do here, however just a few things:

Sat, May 23, 4:44 PM · USB
aokblast added a comment to D52347: usb: support SSP and SSPx2 xHCI.

Just split the patch with multiple smaller one.

Sat, May 23, 10:17 AM · USB
aokblast retitled D52347: usb: support SSP and SSPx2 xHCI from usb: support usb 3.1 (SuperSpeedPlus) and usb 3.2 (SuperSpeedPlus_x2) addressing and display for xhci. to usb: support SSP and SSPx2 xHCI.
Sat, May 23, 10:16 AM · USB
aokblast added reviewers for D57204: usb: Add support for SSP and SSPx2 hubs: USB, adrian.
Sat, May 23, 10:14 AM · USB
aokblast added reviewers for D57203: usb: Add SSPlus device capability descriptor: adrian, USB.
Sat, May 23, 10:13 AM · USB
aokblast added reviewers for D57202: usb: Implement usbd_req_get_bos_descriptor helper: USB, adrian.
Sat, May 23, 10:12 AM · USB
aokblast added reviewers for D57201: usb: Add get_ext_port_status helper function: adrian, USB.
Sat, May 23, 10:11 AM · USB
aokblast added reviewers for D57200: usb: Add extended port status struct: USB, adrian.
Sat, May 23, 10:10 AM · USB
aokblast added reviewers for D57199: usb: Add usb_bos_foreach helper: USB, adrian.
Sat, May 23, 10:09 AM · USB
aokblast added reviewers for D57198: usb: support SSP/SSPx2 devices in all-speed consumers: USB, adrian.
Sat, May 23, 10:08 AM · USB
aokblast added reviewers for D57197: usbdump: Support SSP and SSPx2 speed display: adrian, USB.
Sat, May 23, 10:07 AM · USB
aokblast added reviewers for D57196: usbconfig: Add SSPx2 support: USB, adrian.
Sat, May 23, 10:06 AM · USB
aokblast added reviewers for D57195: libusb: Add SSP and SSPx2 enum support: USB, adrian.
Sat, May 23, 10:04 AM · USB
aokblast added reviewers for D57194: usb: Add SSP and SSPx2 speed and move USB_*_MAX into enum: USB, adrian.
Sat, May 23, 10:03 AM · USB
aokblast updated the diff for D56970: usb: Refactor usb_proc_msg.

Fixes

Sat, May 23, 7:52 AM · USB
aokblast added inline comments to D56970: usb: Refactor usb_proc_msg.
Sat, May 23, 7:41 AM · USB
kevans added inline comments to D56970: usb: Refactor usb_proc_msg.
Sat, May 23, 2:53 AM · USB

Fri, May 22

aokblast added a comment to D56970: usb: Refactor usb_proc_msg.

Sorry, on the list to give this a closer look today- it looked nice on the surface and cleans up one annoyance I've had in the past with how this stuff works, but I want to be sure that we don't accidentally regress the serial bits.

Fri, May 22, 2:39 PM · USB
kevans added a comment to D56970: usb: Refactor usb_proc_msg.

Sorry, on the list to give this a closer look today- it looked nice on the surface and cleans up one annoyance I've had on the last with how this stuff works, but I want to be sure that we don't accidentally regress the serial bits.

Fri, May 22, 2:26 PM · USB
aokblast added a project to D56891: usb_hub: Trigger only chaged port on enumeration: USB.
Fri, May 22, 7:45 AM · USB
aokblast added a project to D56970: usb: Refactor usb_proc_msg: USB.
Fri, May 22, 7:45 AM · USB
aokblast closed D57146: xhci: Do not drop and add bits in xhci.
Fri, May 22, 7:41 AM · USB

Thu, May 21

adrian added a comment to D57146: xhci: Do not drop and add bits in xhci.

This looks fine, is there somewhere in the XHCI specification you can reference for drop bit handling? It'd be good to have a comment there.

Nice catch!

This is a Note in xHCI spec 4.6.8:

The Reset Endpoint Command may only be issued to endpoints in the Halted
state. If software wishes to reset the Data Toggle or Sequence Number of an
endpoint that isn't in the Halted state, then software may issue a Configure
Endpoint Command with the Drop and Add bits set for the target endpoint
that is in the Stopped state or Running but Idle state.

I will attach this in the comment tomorrow, thanks!:)

Thu, May 21, 2:48 PM · USB
aokblast added a comment to D57146: xhci: Do not drop and add bits in xhci.

This looks fine, is there somewhere in the XHCI specification you can reference for drop bit handling? It'd be good to have a comment there.

Nice catch!

Thu, May 21, 2:47 PM · USB
adrian accepted D57146: xhci: Do not drop and add bits in xhci.

This looks fine, is there somewhere in the XHCI specification you can reference for drop bit handling? It'd be good to have a comment there.

Thu, May 21, 2:42 PM · USB
adrian added a project to D57146: xhci: Do not drop and add bits in xhci: USB.
Thu, May 21, 2:39 PM · USB

Mon, May 18

sanpei added a comment to D56985: usb_ethernet: avoid ioctl and watchdog tick link up/down race condition..

Thank you for your effort on this.

Mon, May 18, 12:29 PM · USB

Sat, May 16

unitrunker_gmail.com removed a member for USB: unitrunker_gmail.com.
Sat, May 16, 3:30 AM
unitrunker_unitrunker.net removed a member for USB: unitrunker_unitrunker.net.
Sat, May 16, 3:29 AM
unitrunker_unitrunker.net removed a watcher for USB: unitrunker_unitrunker.net.
Sat, May 16, 3:29 AM
unitrunker_unitrunker.net foisted D54231: libusb20_dev_open(3) and libusb20_be_device_foreach(3) man pages. upon unitrunker_protonmail.com.
Sat, May 16, 3:26 AM · USB
unitrunker_unitrunker.net edited reviewers for D54218: Introduce libusb20_dev_open_with_flags for shared vs. exclusive access., added: unitrunker_protonmail.com; removed: unitrunker_unitrunker.net.
Sat, May 16, 3:24 AM · USB
unitrunker_unitrunker.net edited reviewers for D54296: PR 291774: expand range of errors reported by libusb_open(3), added: unitrunker_protonmail.com; removed: unitrunker_unitrunker.net.
Sat, May 16, 3:23 AM · USB