Page MenuHomeFreeBSD
Differential D56891

usb_hub: Trigger only chaged port on enumeration
Needs ReviewPublic
Actions

Authored by aokblast on May 8 2026, 5:15 PM.
Tags
Referenced Files
F170874772: D56891.diff
Mon, Sep 7, 5:13 AM
Unknown Object (File)
Sun, Sep 6, 2:17 PM
Unknown Object (File)
Sat, Sep 5, 9:13 PM
Unknown Object (File)
Sat, Sep 5, 7:00 PM
Unknown Object (File)
Sat, Sep 5, 11:56 AM
Unknown Object (File)
Fri, Sep 4, 11:35 PM
Unknown Object (File)
Thu, Sep 3, 5:56 PM
Unknown Object (File)
Thu, Sep 3, 5:37 PM
View All 54 Files
Subscribers
bz
imp
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

USB hub records changed ports in every hotplug event interrupt.
Instead of reading port status one by one, we use the data from the
callback to speedup enumeration.
Host Controller also does the same thing. But we don't plan to fix it in
this patch since it requires to aggregate all Port Status Changed TRB.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 72936
Build 69819: arc lint + arc unit

Event Timeline

aokblast created this revision.May 8 2026, 5:15 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 8 2026, 5:15 PM
aokblast requested review of this revision.May 8 2026, 5:15 PM
Harbormaster completed remote builds in B72936: Diff 177469.May 8 2026, 5:15 PM
aokblast added a project: USB.May 22 2026, 7:45 AM
bz added a subscriber: bz.Sat, Sep 5, 9:45 PM
bz added inline comments.
sys/dev/usb/usb_hub.c
2304

You could make this a bool and pass true/false instead of using an uint8_t?

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
controller/
3 lines
2 lines
3 lines
85 lines
16 lines

Diff 177469

View Options

sys/dev/usb/controller/usb_controller.c

Loading...
View Options

sys/dev/usb/usb_handle_request.c

Loading...
View Options

sys/dev/usb/usb_hub.h

Loading...
View Options

sys/dev/usb/usb_hub.c

Loading...
View Options

sys/dev/usb/usb_hub_private.h

Loading...