Differential D57320

usb: Refactor functions need lock
Needs ReviewPublic
Actions

Authored by aokblast on May 29 2026, 7:05 AM.

Tags

Referenced Files

	Unknown Object (File)
	Mon, Jul 6, 2:31 AM

	Unknown Object (File)
	Sun, Jul 5, 1:24 PM

	Unknown Object (File)
	Sun, Jul 5, 8:40 AM

	Unknown Object (File)
	Sun, Jun 28, 11:07 AM

	Unknown Object (File)
	Tue, Jun 23, 2:59 AM

	Unknown Object (File)
	Fri, Jun 19, 4:55 PM

	Unknown Object (File)
	Wed, Jun 17, 11:33 PM

	Unknown Object (File)
	Jun 7 2026, 6:17 AM

View All 18 Files

Subscribers

Details

Reviewers

manu
khorben
adrian

Summary

In the USB subsystem, it is often difficult to determine which functions
require the lock context and which do not. To improve readability and
maintainability, all functions that require the lock context are
renamed with the _locked suffix. In addition, mtx_assert checks are
added to all non-static function and static functions used as function
pointers to sure the correct lock context is held.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73537
Build 70420: arc lint + arc unit

Event Timeline

aokblast created this revision.May 29 2026, 7:05 AM

Herald added a reviewer: manu. · View Herald TranscriptMay 29 2026, 7:05 AM

Herald added a reviewer: khorben. · View Herald Transcript

Herald added subscribers: linuxkpi, glebius, dab and 4 others. · View Herald Transcript

aokblast requested review of this revision.May 29 2026, 7:05 AM

Harbormaster completed remote builds in B73537: Diff 178876.May 29 2026, 7:05 AM

aokblast added a reviewer: adrian.May 29 2026, 7:07 AM

aokblast added a project: USB.

Revision Contents
Changeset List

Path

Size

stand/

kshim/

15 lines

usb/

usb_busdma_loader.c

11 lines

sys/

compat/

linuxkpi/

common/

src/

14 lines

dev/

otus/

22 lines

rtwn/

usb/

rtwn_usb_attach.c

2 lines

4 lines

6 lines

sound/

usb/

50 lines

usb/

controller/

59 lines

59 lines

56 lines

62 lines

61 lines

52 lines

2 lines

73 lines

2 lines

usb_controller.c

131 lines

55 lines

44 lines

gadget/

22 lines

8 lines

22 lines

8 lines

input/

14 lines

14 lines

28 lines

15 lines

20 lines

10 lines

21 lines

8 lines

10 lines

misc/

16 lines

36 lines

26 lines

net/

26 lines

18 lines

18 lines

52 lines

18 lines

18 lines

20 lines

18 lines

22 lines

18 lines

26 lines

18 lines

26 lines

32 lines

18 lines

26 lines

67 lines

74 lines

15 lines

serial/

28 lines

20 lines

28 lines

22 lines

28 lines

14 lines

20 lines

20 lines

51 lines

20 lines

22 lines

20 lines

24 lines

36 lines

24 lines

34 lines

28 lines

28 lines

18 lines

24 lines

16 lines

28 lines

storage/

18 lines

32 lines

32 lines

24 lines

6 lines

27 lines

usb_controller.h

2 lines

4 lines

35 lines

58 lines

usb_handle_request.c

6 lines

2 lines

62 lines

24 lines

14 lines

34 lines

14 lines

16 lines

256 lines

19 lines

video/

12 lines

wlan/

28 lines

20 lines

20 lines

22 lines

28 lines

16 lines

22 lines

24 lines

28 lines

netgraph/

bluetooth/

drivers/

ubt/

28 lines

ubtbcmfw/

16 lines

Diff 178876

stand/kshim/bsd_kernel.c

Loading...

stand/usb/usb_busdma_loader.c

Loading...

sys/compat/linuxkpi/common/src/linux_usb.c

Loading...

sys/dev/otus/if_otus.c

Loading...

sys/dev/rtwn/usb/rtwn_usb_attach.c

Loading...

sys/dev/rtwn/usb/rtwn_usb_rx.c

Loading...

sys/dev/rtwn/usb/rtwn_usb_tx.c

Loading...

sys/dev/sound/usb/uaudio.c

Loading...

sys/dev/usb/controller/atmegadci.c

Loading...

sys/dev/usb/controller/avr32dci.c

Loading...

sys/dev/usb/controller/dwc_otg.c

Loading...

sys/dev/usb/controller/ehci.c

Loading...

sys/dev/usb/controller/musb_otg.c

Loading...

sys/dev/usb/controller/ohci.c

Loading...

sys/dev/usb/controller/uhci.h

Loading...

sys/dev/usb/controller/uhci.c

Loading...

sys/dev/usb/controller/uhci_pci.c

Loading...

sys/dev/usb/controller/usb_controller.c

Loading...

sys/dev/usb/controller/uss820dci.c

Loading...

sys/dev/usb/controller/xhci.c

Loading...

sys/dev/usb/gadget/g_audio.c

Loading...

sys/dev/usb/gadget/g_keyboard.c

Loading...

sys/dev/usb/gadget/g_modem.c

Loading...

sys/dev/usb/gadget/g_mouse.c

Loading...

sys/dev/usb/input/atp.c

Loading...

sys/dev/usb/input/uep.c

Loading...

sys/dev/usb/input/uhid.c

Loading...

sys/dev/usb/input/uhid_snes.c

Loading...

sys/dev/usb/input/ukbd.c

Loading...

sys/dev/usb/input/ums.c

Loading...

sys/dev/usb/input/usbhid.c

Loading...

sys/dev/usb/input/wmt.c

Loading...

sys/dev/usb/input/wsp.c

Loading...

sys/dev/usb/misc/cp2112.c

Loading...

sys/dev/usb/misc/udbp.c

Loading...

sys/dev/usb/misc/ugold.c

Loading...

sys/dev/usb/net/if_aue.c

Loading...

sys/dev/usb/net/if_axe.c

Loading...

sys/dev/usb/net/if_axge.c

Loading...

sys/dev/usb/net/if_cdce.c

Loading...

sys/dev/usb/net/if_cdceem.c

Loading...

sys/dev/usb/net/if_cue.c

Loading...

sys/dev/usb/net/if_ipheth.c

Loading...

sys/dev/usb/net/if_kue.c

Loading...

sys/dev/usb/net/if_mos.c

Loading...

sys/dev/usb/net/if_muge.c

Loading...

sys/dev/usb/net/if_rue.c

Loading...

sys/dev/usb/net/if_smsc.c

Loading...

sys/dev/usb/net/if_udav.c

Loading...

sys/dev/usb/net/if_umb.c

Loading...

sys/dev/usb/net/if_ure.c

Loading...

sys/dev/usb/net/if_urndis.c

Loading...

sys/dev/usb/net/if_usie.c

Loading...

sys/dev/usb/net/uhso.c

Loading...

sys/dev/usb/net/usb_ethernet.c

Loading...

sys/dev/usb/serial/u3g.c

Loading...

sys/dev/usb/serial/uark.c

Loading...

sys/dev/usb/serial/ubsa.c

Loading...

sys/dev/usb/serial/ubser.c

Loading...

sys/dev/usb/serial/uchcom.c

Loading...

sys/dev/usb/serial/ucycom.c

Loading...

sys/dev/usb/serial/udbc.c

Loading...

sys/dev/usb/serial/ufintek.c

Loading...

sys/dev/usb/serial/ufoma.c

Loading...

sys/dev/usb/serial/uftdi.c

Loading...

sys/dev/usb/serial/ugensa.c

Loading...

sys/dev/usb/serial/uipaq.c

Loading...

sys/dev/usb/serial/ulpt.c

Loading...

sys/dev/usb/serial/umcs.c

Loading...

sys/dev/usb/serial/umct.c

Loading...

sys/dev/usb/serial/umodem.c

Loading...

sys/dev/usb/serial/umoscom.c

Loading...

sys/dev/usb/serial/uplcom.c

Loading...

sys/dev/usb/serial/usb_serial.c

Loading...

sys/dev/usb/serial/uslcom.c

Loading...

sys/dev/usb/serial/uvisor.c

Loading...

sys/dev/usb/serial/uvscom.c

Loading...

sys/dev/usb/storage/cfumass.c

Loading...

sys/dev/usb/storage/umass.c

Loading...

sys/dev/usb/storage/urio.c

Loading...

sys/dev/usb/storage/ustorage_fs.c

Loading...

sys/dev/usb/usb_busdma.h

Loading...

sys/dev/usb/usb_busdma.c

Loading...

sys/dev/usb/usb_controller.h

Loading...

sys/dev/usb/usb_device.h

Loading...

sys/dev/usb/usb_device.c

Loading...

sys/dev/usb/usb_generic.c

Loading...

sys/dev/usb/usb_handle_request.c

Loading...

sys/dev/usb/usb_hub.h

Loading...

sys/dev/usb/usb_hub.c

Loading...

sys/dev/usb/usb_msctest.c

Loading...

sys/dev/usb/usb_process.h

Loading...

sys/dev/usb/usb_process.c

Loading...

sys/dev/usb/usb_request.c

Loading...

sys/dev/usb/usb_transfer.h

Loading...

sys/dev/usb/usb_transfer.c

Loading...

sys/dev/usb/usbdi.h

Loading...

sys/dev/usb/video/udl.c

Loading...

sys/dev/usb/wlan/if_mtw.c

Loading...

sys/dev/usb/wlan/if_rsu.c

Loading...

sys/dev/usb/wlan/if_rum.c

Loading...

sys/dev/usb/wlan/if_run.c

Loading...

sys/dev/usb/wlan/if_uath.c

Loading...

sys/dev/usb/wlan/if_upgt.c

Loading...

sys/dev/usb/wlan/if_ural.c

Loading...

sys/dev/usb/wlan/if_urtw.c

Loading...

sys/dev/usb/wlan/if_zyd.c

Loading...

sys/netgraph/bluetooth/drivers/ubt/ng_ubt.c

Loading...

sys/netgraph/bluetooth/drivers/ubtbcmfw/ubtbcmfw.c

Loading...