usb: support SSP and SSPx2 xHCI
Needs ReviewPublic
Actions

Authored by aokblast on Sep 2 2025, 6:44 PM.

Details

Reviewers

adrian

Group Reviewers

USB

Summary

Currently, we only support default PSI id implemented xHCI. For other
xhci, we fallback to 3.0. Note that the total bandwidth of the device
is not so much impacted since all of the setup is done by xHCI
hardware id is compatbile for old xHCI driver.

This driver fix the addressing issue for SSP hub behind a SSP hub and
makes the usb driver detect the speed correctly.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 73375
Build 70258: arc lint + arc unit

Event Timeline

aokblast created this revision.Sep 2 2025, 6:44 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2025, 6:44 PM

aokblast requested review of this revision.Sep 2 2025, 6:44 PM

Harbormaster completed remote builds in B66767: Diff 161389.Sep 2 2025, 6:44 PM

imp added inline comments.Sep 2 2025, 10:09 PM

lib/libusb/libusb20_ugen20.c
210 ↗	(On Diff #161389)	All the lib changes you could do in one commit.
sys/dev/rtwn/rtl8812a/usb/r12au_attach.c
81 ↗	(On Diff #161389)	You can do this as a separate change, maybe combined with others that just do similar things.
sys/dev/usb/storage/umass.c
2362 ↗	(On Diff #161389)	These should have their own transfer speeds, I think.
sys/dev/usb/template/usb_template.c
598 ↗	(On Diff #161389)	2**10 == 1024
602 ↗	(On Diff #161389)	2**11 is 2048
sys/dev/usb/usb.h
814 ↗	(On Diff #161389)	You can roll this into the enum... And I'd be tempted to commit just the extra enums first by itself, since that lets you do many slivers of the change on their own as well.
830 ↗	(On Diff #161389)	Same comment.
sys/dev/usb/usb_hub.c
829 ↗	(On Diff #161389)	why this change?

lwhsu added a subscriber: lwhsu.Sep 3 2025, 1:30 PM

lwhsu added inline comments.

lib/libusb/libusb01.c
135 ↗	(On Diff #161389)

lwhsu added inline comments.Sep 3 2025, 2:16 PM

sys/dev/usb/controller/xhci.c
135
550
552
sys/dev/usb/template/usb_template.c
597 ↗	(On Diff #161389)
601 ↗	(On Diff #161389)
sys/dev/usb/usb.h
412 ↗	(On Diff #161389)	`usb_devcap_ss_plus_descriptor` ?
usr.sbin/usbdump/usbdump.c
165 ↗	(On Diff #161389)	Do we also need to add `USB_SPEED_SUPER_PLUS_X2` ?