In D55893#1278897, @kib wrote:

For now, I suggest to #ifdef 0 the ADD_TEST(), then revert it when the updated test is written.

Does this need MFC?

Quick response:

I'm good for kmods part. For dhcpd, in general it's a good direction. It's a bit pity that we lost the message of needing "ISC dhcp server", as I am not sure if this test works with other dhcpd. Not sure where is the best place to put that information.

Please also put PR: 260891 in the commit message.

This one is done in D42612

ref: https://bugs.freebsd.org/292982

I believe this is fine, for the formal process, maybe it's nice to add this on behalf of srcmgr

Thanks!

I haven't added the ci build, but I assume this has been tested. We may also want to mention gcc15 at https://docs.freebsd.org/en/articles/committers-guide/#_current_compiler_versions

WWW: information?

Do we still need to info of GH_TUPLE in distinfo file?

In D54877#1254532, @bz wrote:

You can normally just commit these. I never ask for review. I think people are just happy if it happens for as long as we don't break the syntax ;-) Thank you!

That's good, then we can have fu540 support longer.

In D54421#1249144, @mhorne wrote:

Bump to latest v1.8.1 and bump fu540 u-boot revision

Just go as the corss-repo commit is encouraged now? BTW this builds fine in my poudriere (all flavors).

In D54720#1253462, @siva wrote:

Thanks for the clarification, I'll keep that in mind for future patches. I think for this case, it's better if you commit it as the maintainer, especially since I'm a new committer.

After much more discussions in many place, the current thought is that having a guideline doc (D54366) and mention this in the committer's guide (D54817).

Might want add references after D54366 and D54817 merged.

BTW, I suggest that we land this patch first, and continue the discussion at https://bugs.freebsd.org/292615

In D54803#1252821, @olce wrote:

In D54803#1252817, @lwhsu wrote:

@khng mentions that there is if (resource_disabled(HWP_AMD_CLASSNAME, 0)) return; in hwpstate_identify() so maybe setting hint.hwpstate_amd.disabled="1" in hint file also works?

That hint completely disables hwpstate_amd, which also contains the good old regular P-state driver. The new knob proposed in this revision just forces the use of that old code instead of the more modern CPPC support.

@khng mentions that there is if (resource_disabled(HWP_AMD_CLASSNAME, 0)) return; in hwpstate_identify() so maybe setting hint.hwpstate_amd.disabled="1" in hint file also works?

IIRC contrib-committers.adoc and pgpkeys/_index.adoc may need to sort by last name, but that can (and should) be done in a separated commit.

Don't forget to bump .Dd on update :-)

Don't forget to bump .Dd field. :-)

remove duplicated part

In D54450#1244273, @antranigv_freebsd.am wrote:

as a matter of fact, this is a good motivation to update the jail.conf examples as well.

I personally think this is a good direction and also what currently in style(9). We have so many copy-n-paste license in the tree, with more or less issues.

I think this is good, and we can consider also include in the template at src/tools/tools/git/hooks/prepare-commit-msg