User Details
- User Since
- May 10 2014, 3:58 PM (596 w, 3 d)
- Roles
- Administrator
Yesterday
To my understanding that having those in tests/ci/tools/freebsdci means running in the testvm, right? If so it means the test environment, i.e., the provisioned VM for running full or smoke tests. I feel it's not necessary to do so and this can be done in the build environment, i.e., the env you run the buildworld and buildkernel commands, and building the VM images. That usually means more efficient and we don't really need to do full build in an env to be tested. We just need to build things (for test) in a verified env.
Sat, Oct 11
Thu, Oct 2
Wed, Oct 1
I think this is fine. Let's add a longer MFC time (say 2 weeks) to ensure there is no regression.
Tue, Sep 30
Sun, Sep 28
Oh, right, I was thinking how to deal with the cases of ${ESP} = "yes" and ${ESP} != "yes", but currently we only need to deal with amd64 and aarch64 and they both have ESP=yes so this should be better than the current situation, which only handles amd64. Thanks!
Sat, Sep 27
Fri, Sep 26
actually remove from tools/tools/net80211
Thu, Sep 25
misplaced.
Mon, Sep 22
Not sure if this patch is still making sense, but maybe some parts are still worth to be picked up.
Wed, Sep 17
Mon, Sep 15
Sep 11 2025
Sep 9 2025
Sep 8 2025
Please corp with the comments about indentation and commit message. Also, we need this MFC to stable/15 at least so please add MFC after: 3 days to be in the next 15.0 build.
Sep 5 2025
check public key file
Remove unnecessary checks.
Sep 3 2025
Sep 1 2025
Aug 31 2025
Aug 27 2025
Oh, it would be better to have the subject like usb: Implement attach kernel driver function or feature or so.
Aug 26 2025
Suggested commit message:
I'm cleaning up small local changes when sorting my git workspace. This patch may need to be improved, but need to get it out my private tree first.
Aug 25 2025
Consider a MFC ?
Aug 23 2025
Also use Fix: field in the commit message.
Aug 22 2025
I think we also need to update usbconfig(8).
I believe this is good enough. Let's have this in -CURRENT first and if we still want to modify the comment, we can do that in the MFC waiting period and then MFC all the changes together.
Suggested commit message:
Aug 21 2025
BTW for the commit message should can mention https://bugs.freebsd.org/288968
Adjusted commit message:
The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like qemu keyboard) may not have LED. Therefore, removing the error check as ukbd(4) does allow the keyboard works correctly with kbdcontrol(4).
The Torrents page contains both latest production and legacy release versions so we may need to mention this in both places, perhaps under the table of each -RELEASE, or putting in the "Choosing an Image" section. For the wording I suggest saying something like The magnet links to download via BitTorrent protocol are available at link:https://wiki.freebsd.org/Torrents[FreeBSD Torrents Wiki page].
BTW we can mention PR 259673 in the commit message.
I believe you mean “multiple modules”
Aug 20 2025
As there seems no license issue in this patch, hand over this to srcmgr.
Aug 18 2025
Aug 14 2025
Aug 13 2025
in man page and code, there are iad_array and iad_arr, would be nice if this naming can be consistent.
Maybe make it optional and can be set in the config so we have "develop" and "release" modes?