Page MenuHomeFreeBSD

lwhsu (Li-Wen Hsu)
UserAdministrator

User Details

User Since
May 10 2014, 3:58 PM (596 w, 3 d)
Roles
Administrator

Recent Activity

Yesterday

lwhsu committed R11:4ad74d54a7a9: devel/jenkins: Update to 2.532 (authored by lwhsu).
devel/jenkins: Update to 2.532
Tue, Oct 14, 7:41 PM
lwhsu added a comment to D53085: tests/ci: Add reproducibility tests.

To my understanding that having those in tests/ci/tools/freebsdci means running in the testvm, right? If so it means the test environment, i.e., the provisioned VM for running full or smoke tests. I feel it's not necessary to do so and this can be done in the build environment, i.e., the env you run the buildworld and buildkernel commands, and building the VM images. That usually means more efficient and we don't really need to do full build in an env to be tested. We just need to build things (for test) in a verified env.

No. This is not possible. I have checked and replenished all possible way for that unless you have an entire better idea for this. Everything can be tested except the date change. Changing the date on the host itself might have catastrophic effect on our build servers and build environment. Which I am not willing to do. And after lots of test on Jenkins and scripts I have come to this conclusion. I am open to ideas but not what you have recommended. Do you remember our discussion that why SOURCE_DATE_EPOCH cannot help us really test the reproducibility on two different dates?

Tue, Oct 14, 6:29 PM
lwhsu added a comment to D53085: tests/ci: Add reproducibility tests.

To my understanding that having those in tests/ci/tools/freebsdci means running in the testvm, right? If so it means the test environment, i.e., the provisioned VM for running full or smoke tests. I feel it's not necessary to do so and this can be done in the build environment, i.e., the env you run the buildworld and buildkernel commands, and building the VM images. That usually means more efficient and we don't really need to do full build in an env to be tested. We just need to build things (for test) in a verified env.

Tue, Oct 14, 3:37 PM

Sat, Oct 11

lwhsu committed R11:deb452654040: devel/jenkins: Update to 2.531 (authored by lwhsu).
devel/jenkins: Update to 2.531
Sat, Oct 11, 9:56 PM

Thu, Oct 2

lwhsu committed rGcb714aa76b1f: wlanstat(8): Rename from wlanstats(8) to keep consistency (authored by lwhsu).
wlanstat(8): Rename from wlanstats(8) to keep consistency
Thu, Oct 2, 5:34 PM
lwhsu committed rGcd790b9ca8af: wlanstat(8): Follow-ups after moving to /usr/sbin and renaming (authored by lwhsu).
wlanstat(8): Follow-ups after moving to /usr/sbin and renaming
Thu, Oct 2, 5:34 PM

Wed, Oct 1

lwhsu accepted D52815: isa_common: add all listed devices.

I think this is fine. Let's add a longer MFC time (say 2 weeks) to ensure there is no regression.

Wed, Oct 1, 2:46 PM

Tue, Sep 30

lwhsu committed rG89eee8ee2ce5: wlanstat(8): Rename from wlanstats(8) to keep consistency (authored by lwhsu).
wlanstat(8): Rename from wlanstats(8) to keep consistency
Tue, Sep 30, 3:33 AM
lwhsu committed rG6952bb321c5c: wlanstat(8): Follow-ups after moving to /usr/sbin and renaming (authored by lwhsu).
wlanstat(8): Follow-ups after moving to /usr/sbin and renaming
Tue, Sep 30, 3:33 AM
lwhsu closed D52724: wlanstat(8): Rename from wlanstats(8) to keep consistency.
Tue, Sep 30, 3:32 AM
lwhsu closed D52726: wlanstat(8): Follow-ups after moving to /usr/sbin and renaming.
Tue, Sep 30, 3:32 AM

Sun, Sep 28

lwhsu accepted D52734: release: Fix booting on aarch64 in Azure by adding the BOOTPARTSOFFSET.

Oh, right, I was thinking how to deal with the cases of ${ESP} = "yes" and ${ESP} != "yes", but currently we only need to deal with amd64 and aarch64 and they both have ESP=yes so this should be better than the current situation, which only handles amd64. Thanks!

Sun, Sep 28, 2:18 PM
lwhsu added inline comments to D52734: release: Fix booting on aarch64 in Azure by adding the BOOTPARTSOFFSET.
Sun, Sep 28, 12:44 PM

Sat, Sep 27

lwhsu added a comment to D52724: wlanstat(8): Rename from wlanstats(8) to keep consistency.

Will this need any adjusting package base?

Sat, Sep 27, 6:38 AM

Fri, Sep 26

lwhsu added inline comments to D52734: release: Fix booting on aarch64 in Azure by adding the BOOTPARTSOFFSET.
Fri, Sep 26, 6:01 PM
lwhsu updated the diff for D52726: wlanstat(8): Follow-ups after moving to /usr/sbin and renaming.

actually remove from tools/tools/net80211

Fri, Sep 26, 1:02 AM

Thu, Sep 25

lwhsu updated the summary of D52726: wlanstat(8): Follow-ups after moving to /usr/sbin and renaming.
Thu, Sep 25, 9:04 AM
lwhsu requested review of D52726: wlanstat(8): Follow-ups after moving to /usr/sbin and renaming.
Thu, Sep 25, 9:03 AM
lwhsu abandoned D52725: wlanstat(8): Rename from wlanstats(8) to keep consistency.

misplaced.

Thu, Sep 25, 8:57 AM
lwhsu requested review of D52725: wlanstat(8): Rename from wlanstats(8) to keep consistency.
Thu, Sep 25, 8:56 AM
lwhsu requested review of D52724: wlanstat(8): Rename from wlanstats(8) to keep consistency.
Thu, Sep 25, 8:52 AM

Mon, Sep 22

lwhsu added a comment to D9157: xHCI Debug Capability support for USB 3.0.

Not sure if this patch is still making sense, but maybe some parts are still worth to be picked up.

It shouldn't be too hard to clean up and throw into the tree. Is there a doc somewhere showing what this was designed to do and how we'd use it?
(God, being able to do remote GDB / remote console over USB 3 debug ports would be great, I just wouldn't know where to start!)

Mon, Sep 22, 12:41 AM
lwhsu added reviewers for D9157: xHCI Debug Capability support for USB 3.0: thj, hrs.

Not sure if this patch is still making sense, but maybe some parts are still worth to be picked up.

Mon, Sep 22, 12:16 AM

Wed, Sep 17

lwhsu committed R11:6242fdaa8ded: security/keepassxc: Disable Yubikey option by default (authored by lwhsu).
security/keepassxc: Disable Yubikey option by default
Wed, Sep 17, 7:48 PM
lwhsu committed R11:92b4e88e4b58: devel/jenkins-lts: Update to 2.516.3 (authored by lwhsu).
devel/jenkins-lts: Update to 2.516.3
Wed, Sep 17, 7:00 PM
lwhsu committed R11:6a4d6f915b99: devel/jenkins: Update to 2.528 (authored by lwhsu).
devel/jenkins: Update to 2.528
Wed, Sep 17, 7:00 PM
lwhsu committed R11:4b66112e57c1: devel/jenkins-lts: Update to 2.516.3 (authored by lwhsu).
devel/jenkins-lts: Update to 2.516.3
Wed, Sep 17, 6:48 PM
lwhsu committed R11:9e36425c890d: security/vuxml: Document Jenkins Security Advisory 2025-09-17 (authored by lwhsu).
security/vuxml: Document Jenkins Security Advisory 2025-09-17
Wed, Sep 17, 6:48 PM
lwhsu committed R11:7a292ef71a09: devel/jenkins: Update to 2.528 (authored by lwhsu).
devel/jenkins: Update to 2.528
Wed, Sep 17, 6:48 PM
lwhsu added inline comments to D52583: RELNOTES: virtual_oss in base.
Wed, Sep 17, 2:20 AM

Mon, Sep 15

lwhsu committed rGa75c3c2c633d: udbc(4): connect to build (authored by lwhsu).
udbc(4): connect to build
Mon, Sep 15, 6:35 PM

Sep 11 2025

lwhsu committed R11:9998e09cbe4d: devel/jenkins: Update 2.527 (authored by lwhsu).
devel/jenkins: Update 2.527
Sep 11 2025, 10:15 AM

Sep 9 2025

lwhsu accepted D52458: Add "WiFi" to page tags.
Sep 9 2025, 7:48 PM
lwhsu accepted D52459: Remove reference to sio(4).
Sep 9 2025, 7:45 PM
lwhsu added a reviewer for D52347: usb: support usb 3.1 (SuperSpeedPlus) and usb 3.2 (SuperSpeedPlus_x2) addressing and display for xhci.: USB.
Sep 9 2025, 4:22 PM
lwhsu added inline comments to D51299: udbc: Add usb debug host mode driver.
Sep 9 2025, 3:48 AM

Sep 8 2025

lwhsu accepted D52423: hdac: Add patch for new Framework 16 inch laptop..

Please corp with the comments about indentation and commit message. Also, we need this MFC to stable/15 at least so please add MFC after: 3 days to be in the next 15.0 build.

Sep 8 2025, 6:46 PM

Sep 5 2025

lwhsu added a comment to D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint.

I wonder if we should also check for presence of the public key.

Sep 5 2025, 8:44 PM
lwhsu updated the diff for D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint.

check public key file

Sep 5 2025, 8:43 PM
lwhsu added a comment to D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint.

Do you know if there's some canonical reference for emitting the fingerprints to the system console on startup? Searching for -----BEGIN SSH HOST KEY FINGERPRINTS----- turns up lots of examples, but if there is some canonical reference it would be good to include here.

Sep 5 2025, 7:13 PM
lwhsu updated the diff for D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint.

Remove unnecessary checks.

Sep 5 2025, 7:12 PM

Sep 3 2025

lwhsu added inline comments to D52321: usb: Add support for SSPlus isochronous companion descriptor.
Sep 3 2025, 2:19 PM
lwhsu added inline comments to D52347: usb: support usb 3.1 (SuperSpeedPlus) and usb 3.2 (SuperSpeedPlus_x2) addressing and display for xhci..
Sep 3 2025, 2:16 PM
lwhsu added inline comments to D52347: usb: support usb 3.1 (SuperSpeedPlus) and usb 3.2 (SuperSpeedPlus_x2) addressing and display for xhci..
Sep 3 2025, 1:30 PM

Sep 1 2025

lwhsu closed D52318: lang/janet: update to 1.39.1.
Sep 1 2025, 5:53 PM
lwhsu committed R11:849b662c524f: lang/janet: Update to 1.39.1 (authored by hsw_bitmark.com).
lang/janet: Update to 1.39.1
Sep 1 2025, 5:53 PM
lwhsu accepted D52318: lang/janet: update to 1.39.1.
Sep 1 2025, 5:47 PM

Aug 31 2025

lwhsu added inline comments to D52166: bhyve: implement single USB device passthrough support.
Aug 31 2025, 12:55 PM

Aug 27 2025

lwhsu added a comment to D52122: usb: implement attach kernel driver.

Oh, it would be better to have the subject like usb: Implement attach kernel driver function or feature or so.

Aug 27 2025, 1:29 PM
lwhsu accepted D52122: usb: implement attach kernel driver.
Aug 27 2025, 1:26 PM

Aug 26 2025

lwhsu added inline comments to D52166: bhyve: implement single USB device passthrough support.
Aug 26 2025, 5:24 PM
lwhsu added inline comments to D52122: usb: implement attach kernel driver.
Aug 26 2025, 11:50 AM
lwhsu added inline comments to D52152: i6300esbwd: Note update in RELNOTES.
Aug 26 2025, 4:37 AM
lwhsu accepted D52152: i6300esbwd: Note update in RELNOTES.

Suggested commit message:

Aug 26 2025, 4:35 AM
lwhsu added a comment to D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint.

I'm cleaning up small local changes when sorting my git workspace. This patch may need to be improved, but need to get it out my private tree first.

Aug 26 2025, 4:27 AM
lwhsu added reviewers for D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint: cperciva, emaste, delphij.
Aug 26 2025, 4:27 AM
lwhsu requested review of D52159: rc.d/sshd: Add "showfp" cmd to display host key fingerprint.
Aug 26 2025, 4:24 AM

Aug 25 2025

lwhsu accepted D52049: ichwd: introduce i6300esb watch dog driver.

Consider a MFC ?

Aug 25 2025, 3:18 PM

Aug 23 2025

lwhsu added inline comments to D51589: amdgpio: Suspend routine.
Aug 23 2025, 9:11 PM
lwhsu accepted D52135: hkbd: fix compliation error for GENERIC build.

Also use Fix: field in the commit message.

Aug 23 2025, 7:29 AM
lwhsu added inline comments to D51225: libusb: implement libusb_get_max_alt_packet_size.
Aug 23 2025, 1:32 AM
lwhsu added inline comments to D50958: libusb: add parser for interface association descriptor.
Aug 23 2025, 1:26 AM

Aug 22 2025

lwhsu added inline comments to D52122: usb: implement attach kernel driver.
Aug 22 2025, 8:11 PM
lwhsu added a comment to D52122: usb: implement attach kernel driver.

I think we also need to update usbconfig(8).

Aug 22 2025, 8:07 PM
lwhsu accepted D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

I believe this is good enough. Let's have this in -CURRENT first and if we still want to modify the comment, we can do that in the MFC waiting period and then MFC all the changes together.

Aug 22 2025, 7:35 PM
lwhsu added a reviewer for D52122: usb: implement attach kernel driver: USB.
Aug 22 2025, 6:14 PM
lwhsu accepted D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

Suggested commit message:

Aug 22 2025, 3:48 AM
lwhsu accepted D52104: Status/2025Q2/kw-hackathon.adoc: Add report.
Aug 22 2025, 1:42 AM

Aug 21 2025

lwhsu added a comment to D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

I mentioned perhaps making hkbd_no_leds a normal sysctl is that it can be used as a workaround for people in ticket 288968.

I locate the problem inside qemu and do some modification then it works. I will submit a patch to qemu later.

That's great. I feel then we have one more reason to have that sysctl to let people to workaround it before qemu having a new release and being deployed to the production environments.

Wouldn't it means I need to create another patch for that? Why not just use the fix in here?

Aug 21 2025, 9:24 PM
lwhsu added a comment to D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

I mentioned perhaps making hkbd_no_leds a normal sysctl is that it can be used as a workaround for people in ticket 288968.

I locate the problem inside qemu and do some modification then it works. I will submit a patch to qemu later.

Aug 21 2025, 6:53 PM
lwhsu added a comment to D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

The previous comment is incorrect. I check the HID document. HID has a usage page to locate the LED stuff. And FreeBSD kernel does check if such usage page exists. The problem maybe comes from qemu.

Aug 21 2025, 6:28 PM
lwhsu added a comment to D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

BTW for the commit message should can mention https://bugs.freebsd.org/288968

Aug 21 2025, 5:59 PM
lwhsu added a comment to D52101: hkbd: remove erorr detection in KDSKBSTATE ioctl.

Adjusted commit message:

The KDSKBSTATE ioctl brings the LED up. However, some keyboards (like qemu
keyboard) may not have LED. Therefore, removing the error check as ukbd(4)
does allow the keyboard works correctly with kbdcontrol(4).
Aug 21 2025, 5:53 PM
lwhsu added a reviewer for D51904: Add a link to the Torrent downloads: jmg.

The Torrents page contains both latest production and legacy release versions so we may need to mention this in both places, perhaps under the table of each -RELEASE, or putting in the "Choosing an Image" section. For the wording I suggest saying something like The magnet links to download via BitTorrent protocol are available at link:https://wiki.freebsd.org/Torrents[FreeBSD Torrents Wiki page].

Aug 21 2025, 10:01 AM
lwhsu added a comment to D52049: ichwd: introduce i6300esb watch dog driver.

BTW we can mention PR 259673 in the commit message.

Aug 21 2025, 9:10 AM
lwhsu accepted D52062: sys/modules: fix standalone build for multiple build.

I believe you mean “multiple modules”

Aug 21 2025, 8:33 AM
lwhsu added inline comments to D52049: ichwd: introduce i6300esb watch dog driver.
Aug 21 2025, 3:36 AM
lwhsu added inline comments to D52049: ichwd: introduce i6300esb watch dog driver.
Aug 21 2025, 3:26 AM
lwhsu added reviewers for D52049: ichwd: introduce i6300esb watch dog driver: avg, des, markj, lwhsu.
Aug 21 2025, 2:35 AM

Aug 20 2025

lwhsu committed R11:a21dd879f34d: devel/jenkins-lts: Update to 2.516.2 (authored by lwhsu).
devel/jenkins-lts: Update to 2.516.2
Aug 20 2025, 6:50 PM
lwhsu committed R11:da1d4d7a7bad: devel/jenkins: Update to 2.524 (authored by lwhsu).
devel/jenkins: Update to 2.524
Aug 20 2025, 6:50 PM
lwhsu edited reviewers for D18832: NTB Perf: Tool to measure performance of NTB hw drivers, added: srcmgr; removed: Core Team.

As there seems no license issue in this patch, hand over this to srcmgr.

Aug 20 2025, 1:22 AM

Aug 18 2025

lwhsu added inline comments to D51759: libusb: implement zlp flag in libusb transfer.
Aug 18 2025, 6:18 AM

Aug 14 2025

lwhsu added inline comments to D51225: libusb: implement libusb_get_max_alt_packet_size.
Aug 14 2025, 5:21 PM
lwhsu renamed khorben from khorben_defora.org to khorben.
Aug 14 2025, 2:21 PM

Aug 13 2025

lwhsu committed rG178b9c236474: tests/ci: Add missing kmods and pkgs to unskip tests (authored by guest-svmhdvn).
tests/ci: Add missing kmods and pkgs to unskip tests
Aug 13 2025, 9:06 PM
lwhsu closed D51309: tests/ci: add missing kmods and pkgs to unskip tests.
Aug 13 2025, 9:06 PM
lwhsu committed rGad9b27e097b1: tests/ci: style: canonicalize, sort, and multiline kmods/pkgs (authored by guest-svmhdvn).
tests/ci: style: canonicalize, sort, and multiline kmods/pkgs
Aug 13 2025, 9:03 PM
lwhsu closed D51308: tests/ci: style: canonicalize, sort, and multiline kmods/pkgs.
Aug 13 2025, 9:03 PM
lwhsu committed rGe990e460d50c: tests/ci: Fix unescaped kld_list var in rc.conf (authored by guest-svmhdvn).
tests/ci: Fix unescaped kld_list var in rc.conf
Aug 13 2025, 8:31 PM
lwhsu closed D51305: tests/ci: fix unescaped kld_list var in rc.conf.
Aug 13 2025, 8:31 PM
lwhsu committed rG92a7f2d57763: tests/ci: Add KYUA_TEST_FILTERS to allow user to select specific tests (authored by guest-svmhdvn).
tests/ci: Add KYUA_TEST_FILTERS to allow user to select specific tests
Aug 13 2025, 8:12 PM
lwhsu closed D51306: tests/ci: add KYUA_TEST_FILTERS to allow user to select specific tests.
Aug 13 2025, 8:11 PM
lwhsu added a comment to D50958: libusb: add parser for interface association descriptor.

in man page and code, there are iad_array and iad_arr, would be nice if this naming can be consistent.

Aug 13 2025, 6:54 PM
lwhsu accepted D51306: tests/ci: add KYUA_TEST_FILTERS to allow user to select specific tests.
Aug 13 2025, 3:42 PM
lwhsu added reviewers for D51873: java/bootstrap-openjdk17: Require compat14x: haraldei_anduin.net, glewis.
Aug 13 2025, 4:37 AM
lwhsu added a comment to D51882: release: Stop suppressing errors from VM image creation scripts.

Maybe make it optional and can be set in the config so we have "develop" and "release" modes?

Aug 13 2025, 4:35 AM

Aug 12 2025

lwhsu committed R11:07815a57b2d6: devel/jenkins: Update to 2.523 (authored by lwhsu).
devel/jenkins: Update to 2.523
Aug 12 2025, 7:00 PM
lwhsu added inline comments to D49431: ipheth: add ncm support for rx.
Aug 12 2025, 5:45 PM
lwhsu accepted D51867: usbtest: fix usbtest compilation error about unused variable.
Aug 12 2025, 7:38 AM