dhclient/tests: use require.kmods property instead of ad-hoc checks
Needs ReviewPublic
Actions

Authored by siva on Feb 10 2026, 3:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 11, 7:03 AM

	Unknown Object (File)
	Tue, Aug 11, 2:09 AM

	Unknown Object (File)
	Mon, Aug 10, 10:44 AM

	Unknown Object (File)
	Mon, Aug 10, 10:41 AM

	Unknown Object (File)
	Mon, Aug 10, 8:40 AM

	Unknown Object (File)
	Mon, Aug 10, 6:39 AM

	Unknown Object (File)
	Mon, Aug 10, 6:02 AM

	Unknown Object (File)
	Sun, Aug 9, 11:19 PM

View All 71 Files

Subscribers

imp

Details

Reviewers

jmg
lwhsu

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

siva created this revision.Feb 10 2026, 3:44 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2026, 3:44 PM

siva requested review of this revision.Feb 10 2026, 3:44 PM

Harbormaster completed remote builds in B70582: Diff 171676.Feb 10 2026, 3:44 PM

I'm good for kmods part. For dhcpd, in general it's a good direction. It's a bit pity that we lost the message of needing "ISC dhcp server", as I am not sure if this test works with other dhcpd. Not sure where is the best place to put that information.

Added a comment pointing to the pkg origin of dhcpd

Harbormaster completed remote builds in B70609: Diff 171709.Feb 10 2026, 10:26 PM

Updated from discussion offline. I will commit this version instead. I will figure out a way to add "skip reason" metadata to Kyua in a future patch.

Revision Contents
Changeset List

Path

Size

sbin/

dhclient/

tests/

pcp.sh

6 lines

Diff 171826

View Options

sbin/dhclient/tests/pcp.sh

dhclient/tests: use require.kmods property instead of ad-hoc checksNeeds ReviewPublicActions