dhclient/tests: use require.kmods property instead of ad-hoc checks
Needs ReviewPublic
Actions

Authored by siva on Feb 10 2026, 3:44 PM.

Tags

None

Referenced Files

	F163165067: D55222.id171709.diff
	Mon, Jul 20, 4:32 PM

	F163146270: D55222.id171826.diff
	Mon, Jul 20, 12:38 PM

	F163136731: D55222.id171676.diff
	Mon, Jul 20, 10:24 AM

	Unknown Object (File)
	Sat, Jul 18, 12:06 PM

	Unknown Object (File)
	Fri, Jul 3, 7:00 AM

	Unknown Object (File)
	May 21 2026, 4:17 AM

	Unknown Object (File)
	May 18 2026, 3:08 PM

	Unknown Object (File)
	May 17 2026, 4:24 PM

View All 49 Files

Subscribers

imp

Details

Reviewers

jmg
lwhsu

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

siva created this revision.Feb 10 2026, 3:44 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2026, 3:44 PM

siva requested review of this revision.Feb 10 2026, 3:44 PM

Harbormaster completed remote builds in B70582: Diff 171676.Feb 10 2026, 3:44 PM

I'm good for kmods part. For dhcpd, in general it's a good direction. It's a bit pity that we lost the message of needing "ISC dhcp server", as I am not sure if this test works with other dhcpd. Not sure where is the best place to put that information.

Added a comment pointing to the pkg origin of dhcpd

Harbormaster completed remote builds in B70609: Diff 171709.Feb 10 2026, 10:26 PM

Updated from discussion offline. I will commit this version instead. I will figure out a way to add "skip reason" metadata to Kyua in a future patch.

Revision Contents
Changeset List

Path

Size

sbin/

dhclient/

tests/

pcp.sh

6 lines

Diff 171826

View Options

sbin/dhclient/tests/pcp.sh

dhclient/tests: use require.kmods property instead of ad-hoc checksNeeds ReviewPublicActions