Page MenuHomeFreeBSD
Differential D55222

dhclient/tests: use require.kmods property instead of ad-hoc checks
Needs ReviewPublic
Actions

Authored by siva on Tue, Feb 10, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 12, 5:19 PM
Unknown Object (File)
Thu, Feb 12, 4:17 AM
Unknown Object (File)
Thu, Feb 12, 2:33 AM
Unknown Object (File)
Wed, Feb 11, 11:26 PM
Unknown Object (File)
Wed, Feb 11, 6:17 AM
Unknown Object (File)
Wed, Feb 11, 1:13 AM
Unknown Object (File)
Tue, Feb 10, 10:57 PM
Unknown Object (File)
Tue, Feb 10, 7:17 PM
Subscribers
imp

Details

Reviewers
jmg
lwhsu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

siva created this revision.Tue, Feb 10, 3:44 PM
Herald added a subscriber: imp. · View Herald TranscriptTue, Feb 10, 3:44 PM
siva requested review of this revision.Tue, Feb 10, 3:44 PM
Harbormaster completed remote builds in B70582: Diff 171676.Tue, Feb 10, 3:44 PM
lwhsu added a comment.Tue, Feb 10, 7:44 PM

I'm good for kmods part. For dhcpd, in general it's a good direction. It's a bit pity that we lost the message of needing "ISC dhcp server", as I am not sure if this test works with other dhcpd. Not sure where is the best place to put that information.

siva updated this revision to Diff 171709.Tue, Feb 10, 10:26 PM

Added a comment pointing to the pkg origin of dhcpd

Harbormaster completed remote builds in B70609: Diff 171709.Tue, Feb 10, 10:26 PM
siva updated this revision to Diff 171826.Thu, Feb 12, 3:00 PM
siva retitled this revision from dhclient/tests: use metadata to load progs/kmods instead of ad-hoc checks to dhclient/tests: use require.kmods property instead of ad-hoc checks.

Updated from discussion offline. I will commit this version instead. I will figure out a way to add "skip reason" metadata to Kyua in a future patch.

Revision Contents
Changeset List

PathSize
sbin/
dhclient/
tests/
6 lines

Diff 171826

View Options

sbin/dhclient/tests/pcp.sh

Loading...