Page MenuHomeFreeBSD

dhclient/tests: use require.kmods property instead of ad-hoc checks
Needs ReviewPublic

Authored by siva on Feb 10 2026, 3:44 PM.
Tags
None
Referenced Files
F154105794: D55222.id171676.diff
Sun, Apr 26, 5:52 AM
Unknown Object (File)
Tue, Apr 21, 9:42 AM
Unknown Object (File)
Mon, Apr 20, 5:30 PM
Unknown Object (File)
Sun, Apr 12, 7:49 PM
Unknown Object (File)
Sun, Apr 12, 12:31 AM
Unknown Object (File)
Wed, Apr 8, 9:50 AM
Unknown Object (File)
Mon, Apr 6, 8:54 PM
Unknown Object (File)
Sun, Apr 5, 1:06 PM
Subscribers

Details

Reviewers
jmg
lwhsu

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70609
Build 67492: arc lint + arc unit

Event Timeline

siva requested review of this revision.Feb 10 2026, 3:44 PM

I'm good for kmods part. For dhcpd, in general it's a good direction. It's a bit pity that we lost the message of needing "ISC dhcp server", as I am not sure if this test works with other dhcpd. Not sure where is the best place to put that information.

Added a comment pointing to the pkg origin of dhcpd

siva retitled this revision from dhclient/tests: use metadata to load progs/kmods instead of ad-hoc checks to dhclient/tests: use require.kmods property instead of ad-hoc checks.

Updated from discussion offline. I will commit this version instead. I will figure out a way to add "skip reason" metadata to Kyua in a future patch.