lang/jpm: update email - add runtime dependencies
AcceptedPublic
Actions

Authored by hsw_bitmark.com on Fri, Dec 12, 3:49 AM.

Details

Reviewers

dave_freedave.net

Group Reviewers

Contributor Reviewers (ports)

Summary

Update to my working email address, same as lang/janet. So as to receive any version change email in the future.
Add janet as runtime dependency since jpm is just a script that uses janet executable.
Add git since "jmp deps" requires it.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 69284
Build 66167: arc lint + arc unit

Event Timeline

hsw_bitmark.com requested review of this revision.Fri, Dec 12, 3:49 AM

hsw_bitmark.com created this revision.

Harbormaster completed remote builds in B69192: Diff 167898.Fri, Dec 12, 3:49 AM

dave_freedave.net added a subscriber: dave_freedave.net.Fri, Dec 12, 2:32 PM

dave_freedave.net added inline comments.

lang/jpm/Makefile
14–16	Shouldn't this just be DEPENDS since it needs janet at runtime too? Also it needs git at runtime for `janet deps`.

at least it would need an additional RUN_DEPENDS - I will do some tests

Unfortunately my update to 15 had made the poudriere jail very slow (10x slower) and unstable build randomly fails
with pkg static errors like: libgcrypt/1.11.2/15_0-amd64-default.log:pkg-static: Fail to chmod /5.42/perl/man/man3/Pod::Perldoc::ToTk.3.gz:Bad file descriptor

dave_freedave.net mentioned this in D54238: [NEW PORT] devel/janet-lsp.Mon, Dec 15, 4:55 PM

add run time dependencies

Harbormaster completed remote builds in B69284: Diff 168162.Tue, Dec 16, 3:42 AM

hsw_bitmark.com marked an inline comment as done.Tue, Dec 16, 3:43 AM

hsw_bitmark.com retitled this revision from lang/jpm: update email to lang/jpm: update email - add runtime dependencies.Tue, Dec 16, 3:57 AM

hsw_bitmark.com edited the summary of this revision. (Show Details)

Thanks for adding RUN_DEPENDS to port.

This revision is now accepted and ready to land.Wed, Dec 17, 4:40 PM

dave_freedave.net mentioned this in D54260: update janet-lsp to be a "binscript" so it doesn't need to be updated whenever janet is updated.Wed, Dec 17, 5:31 PM