Differential D55221

mixer/tests: use require.kmods property instead of ad-hoc checks
ClosedPublic
Actions

Authored by siva on Feb 10 2026, 3:07 PM.

Tags

None

Referenced Files

	F167595937: D55221.id.diff
	Sat, Aug 22, 11:58 PM

	Unknown Object (File)
	Wed, Aug 19, 2:58 PM

	Unknown Object (File)
	Mon, Aug 17, 11:17 PM

	Unknown Object (File)
	Sat, Aug 15, 1:03 PM

	Unknown Object (File)
	Fri, Aug 14, 4:22 PM

	Unknown Object (File)
	Wed, Aug 12, 7:14 PM

	Unknown Object (File)
	Wed, Aug 12, 7:04 PM

	Unknown Object (File)
	Wed, Aug 12, 6:42 AM

View All 79 Files

Subscribers

Details

Reviewers

christos
lwhsu

Commits

rGef7724764a1d: mixer/tests: use require.kmods property instead of ad-hoc checks
rG3bd7deffdda7: mixer/tests: use require.kmods property instead of ad-hoc checks
rG5fa297f4bcd2: mixer/tests: use require.kmods property instead of ad-hoc checks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

siva created this revision.Feb 10 2026, 3:07 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 10 2026, 3:07 PM

siva requested review of this revision.Feb 10 2026, 3:07 PM

Harbormaster completed remote builds in B70581: Diff 171649.Feb 10 2026, 3:07 PM

lwhsu accepted this revision.Feb 10 2026, 7:40 PM

This revision is now accepted and ready to land.Feb 10 2026, 7:40 PM

christos added inline comments.Feb 10 2026, 10:05 PM

usr.sbin/mixer/tests/Makefile
5	Isn't it cleaner for this to be inside the test script?

siva added inline comments.Feb 10 2026, 10:22 PM

usr.sbin/mixer/tests/Makefile
5	It's a bit simpler to add it here just to avoid so much duplication, because there are exactly 5 tests and all of them need this. Currently, it is equivalent.

christos accepted this revision.Feb 10 2026, 11:02 PM

Closed by commit rG5fa297f4bcd2: mixer/tests: use require.kmods property instead of ad-hoc checks (authored by siva). · Explain WhyFeb 12 2026, 3:04 PM

This revision was automatically updated to reflect the committed changes.

siva added a commit: rG5fa297f4bcd2: mixer/tests: use require.kmods property instead of ad-hoc checks.

christos added a commit: rG3bd7deffdda7: mixer/tests: use require.kmods property instead of ad-hoc checks.Feb 17 2026, 12:52 PM

siva added a commit: rGef7724764a1d: mixer/tests: use require.kmods property instead of ad-hoc checks.Jun 26 2026, 5:00 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

tests/

3 lines

12 lines

Diff 171828

usr.sbin/mixer/tests/Makefile

Loading...

usr.sbin/mixer/tests/mixer_test.sh

Loading...