acpi_bus: Fix acpi_get_flag error.
ClosedPublic
Actions

Authored by aokblast on Sun, Mar 1, 8:51 PM.

Details

Reviewers

obiwac
delphij

Summary

Witness is not happy on acpi_get_flags failure in acpi_wake_set_sysctl.
The kernel panic when a acpi pci device read ivar in PCI-PCI bus.
We extend acpi_pcib_{read,write}_ivar to let it be happy.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71132
Build 68015: arc lint + arc unit

Event Timeline

aokblast created this revision.Sun, Mar 1, 8:51 PM

Herald added a subscriber: imp. · View Herald TranscriptSun, Mar 1, 8:51 PM

aokblast requested review of this revision.Sun, Mar 1, 8:51 PM

Harbormaster completed remote builds in B71120: Diff 172982.Sun, Mar 1, 8:51 PM

aokblast added a reviewer: obiwac.Sun, Mar 1, 8:53 PM

Fix indentation

Harbormaster completed remote builds in B71132: Diff 173009.Mon, Mar 2, 3:09 PM

aokblast edited the summary of this revision. (Show Details)Mon, Mar 2, 3:15 PM

delphij accepted this revision.Mon, Mar 2, 4:28 PM

This revision is now accepted and ready to land.Mon, Mar 2, 4:28 PM

Does this need MFC?

For the commit message: The kernel panic"S" when a"n" acpi pci device read"s" ivar in PCI-PCI bus.

obiwac mentioned this in D55562: acpi: Don't attach a "wake" sysctl node to devices without the ACPI flags IVAR.Wed, Mar 4, 1:51 PM

This is actually not correct, please see my other stack of reviews. We are adding this node twice for some PCI buses, and this just ensures we add it twice for every bus. In particular, see the description in D55563.

jhb@'s patch is much better.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_pcib_pci.c

16 lines

Diff 173009

View Options

sys/dev/acpica/acpi_pcib_pci.c

acpi_bus: Fix acpi_get_flag error.ClosedPublicActions