mail/msmtp: remove ca_root_nss dep

[siva]

Summary

msmtp 1.8.2[0] onwards selects the system trust store by
default when TLS is enabled, so ca_root_nss is no longer
necessary.

Other minor changes:

• PORTVERSION -> DISTVERSION
• enable test suite
• simplify Makefile style

[0] https://marlam.de/msmtp/news/msmtp-1-8-2/

Test Plan

Tried a simple TLS test email to my personal gmail on port 465 with tls=on, starttls=off, with both GNUTLS and OPENSSL. Everything works out of the box, even without specifying tls_trust_file.

[novel]

Looks good, a couple of minor questions.

mail/msmtp/Makefile

2

We also need to bump PORTREVISION because we remove a dependency -> changing the resulting package.

51

It would be nice to extend summary with information why this dependency is not needed anymore.

[siva]

Added better description and link to changelog for evidence, bumped PORTREVISION.

[novel]

Thanks, feel free to merge!

[siva]

Thanks! Although I don't have a ports commit bit yet, so you'll have to do it :)

[novel]

In D54720#1251266, @siva wrote:

Thanks! Although I don't have a ports commit bit yet, so you'll have to do it :)

Actually you can commit to other trees (preferably with appropriate approval), so you can do it.
Of course I can commit it myself if your prefer.

[siva]

Thanks for the clarification, I'll keep that in mind for future patches. I think for this case, it's better if you commit it as the maintainer, especially since I'm a new committer.

[lwhsu]

In D54720#1253462, @siva wrote:

Thanks for the clarification, I'll keep that in mind for future patches. I think for this case, it's better if you commit it as the maintainer, especially since I'm a new committer.

We encourage new people to try more things ;-) if you want to commit, I approve this as the mentor. And cross tree commit is also encouraged now.

[siva]

Sure, I'll commit it then. Thanks for the approval!