Page MenuHomeFreeBSD

mail/msmtp: remove ca_root_nss dep
AcceptedPublic

Authored by siva on Wed, Jan 14, 8:34 PM.
Tags
None
Referenced Files
F142324104: D54720.diff
Sun, Jan 18, 2:29 PM
Unknown Object (File)
Fri, Jan 16, 8:32 AM
Unknown Object (File)
Fri, Jan 16, 6:43 AM
Unknown Object (File)
Fri, Jan 16, 12:43 AM
Unknown Object (File)
Thu, Jan 15, 5:32 PM
Unknown Object (File)
Thu, Jan 15, 7:37 AM
Unknown Object (File)
Thu, Jan 15, 7:28 AM
Unknown Object (File)
Thu, Jan 15, 7:24 AM
Subscribers
None

Details

Reviewers
novel
Summary

msmtp 1.8.2[0] onwards selects the system trust store by
default when TLS is enabled, so ca_root_nss is no longer
necessary.

Other minor changes:

  • PORTVERSION -> DISTVERSION
  • enable test suite
  • simplify Makefile style

[0] https://marlam.de/msmtp/news/msmtp-1-8-2/

Test Plan

Tried a simple TLS test email to my personal gmail on port 465 with tls=on, starttls=off, with both GNUTLS and OPENSSL. Everything works out of the box, even without specifying tls_trust_file.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

siva requested review of this revision.Wed, Jan 14, 8:34 PM
siva created this revision.

Looks good, a couple of minor questions.

mail/msmtp/Makefile
2–3

We also need to bump PORTREVISION because we remove a dependency -> changing the resulting package.

51

It would be nice to extend summary with information why this dependency is not needed anymore.

This revision is now accepted and ready to land.Thu, Jan 15, 7:08 PM
siva edited the summary of this revision. (Show Details)

Added better description and link to changelog for evidence, bumped PORTREVISION.

This revision now requires review to proceed.Fri, Jan 16, 1:47 AM

Thanks, feel free to merge!

This revision is now accepted and ready to land.Sat, Jan 17, 9:15 AM

Thanks! Although I don't have a ports commit bit yet, so you'll have to do it :)

Thanks! Although I don't have a ports commit bit yet, so you'll have to do it :)

Actually you can commit to other trees (preferably with appropriate approval), so you can do it.
Of course I can commit it myself if your prefer.