In D26966#618727, @pfg wrote:In D26966#618725, @yuripv wrote:Looks like export is only ever used in export_pam_environment(), where its return value is ignored.
Yes, I see :-/
So the change is useless, as are the checks for the pre-conditions.It was really nice to see FreeBSD mentioned in a software security course though.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Dec 20 2020
Dec 20 2020
Dec 19 2020
Dec 19 2020
yuripv added a comment to D26966: login: add a check for a post-condition when exporting the environment.
yuripv added a comment to D26966: login: add a check for a post-condition when exporting the environment.
Looks like export is only ever used in export_pam_environment(), where its return value is ignored.
Dec 18 2020
Dec 18 2020
tools/tools/locale: fix static-colldef
tools/tools/locale: install generated files in current src checkout
Dec 17 2020
Dec 17 2020
nl_langinfo(3): document recognized item names
Dec 16 2020
Dec 16 2020
Dec 15 2020
Dec 15 2020
In D27623#617271, @0mp wrote:Hmm, maybe it's better to keep the example shorter as in the err(3) manual page?
In D27623#617254, @0mp wrote:@yuripv, let me know if that's a nice addition to the manual page or not. :) I understand it's basic stuff, but I feel like it's nice to show common patterns in a manual for reference.
Dec 14 2020
Dec 14 2020
Dec 13 2020
Dec 13 2020
Dec 12 2020
Dec 12 2020
locale: fix mode for installed files to be 644, not 755
As I was going through MFCing locale changes, I noticed one little (BIG) problem with this review/commit -- it forgot to actually install the updated sources to share/ subdirectories, so we currently ship what was previous version in share/.
xargs: compile yesexpr as ERE
Dec 10 2020
Dec 10 2020
Dec 8 2020
Dec 8 2020
In D17737#478038, @bapt wrote:did you forget that one?
Committed in rS368390, not sure why phabricator didn't grok it.
Dec 6 2020
Dec 6 2020
update wcwidth data from utf8proc
Dec 4 2020
Dec 4 2020
Dec 2 2020
Dec 2 2020
Nov 30 2020
Nov 30 2020
Nov 29 2020
Nov 29 2020
security(7): fix copy/paste error and correct aslr oids
hwpstate_intel: don't unconditionally print the error message
Nov 28 2020
Nov 28 2020
Nov 25 2020
Nov 25 2020
Nov 23 2020
Nov 23 2020
yuripv added inline comments to D27204: getprogname.3: Show difference between getprogname() and argv[0] in an example.
Nov 22 2020
Nov 22 2020
yuripv added inline comments to D27204: getprogname.3: Show difference between getprogname() and argv[0] in an example.
yuripv added inline comments to D27204: getprogname.3: Show difference between getprogname() and argv[0] in an example.
Nov 21 2020
Nov 21 2020
Nov 19 2020
Nov 19 2020
- rewrite (actually copy and modify utf8-rollup.pl) mkwidths in perl, making it 300x faster compared to sh version
- add to README
- use pkgconf to get utf8proc cflags/libs
Nov 17 2020
Nov 17 2020
context
Jul 27 2020
Jul 27 2020
Jul 26 2020
Jul 26 2020
sed: treat '[' as ordinary character in 'y' command
Jul 14 2020
Jul 14 2020
top: VIS_SAFE turned out to be unsafe
Jul 13 2020
Jul 13 2020
In D25640#567601, @pfg wrote:LGTM however, I would recommend an exp-run. Many times before have sed changes caused trouble in the ports tree to be later reverted.
In D25398#560911, @pstef wrote:It's not immediately obvious to me why rS29310 would render this a no-op, but I know that the use of ki_estcpu instead of ki_pctcpu is bogus for anything but the 4BSD scheduler.
remove debugging cruft
sed/multi_test: print comment for current test, not next one
Jul 11 2020
Jul 11 2020
Jun 23 2020
Jun 23 2020
Jun 22 2020
Jun 22 2020
Jun 21 2020
Jun 21 2020
w: use locale-based string format specifiers
Jun 18 2020
Jun 18 2020
I think this looks good.
Jun 15 2020
Jun 15 2020
Jun 13 2020
Jun 13 2020
nvi: fallback to ISO8859-1 as last resort
awk(1): use -version instead of -V
locale: exit 1 if unknown keyword was specified
Jun 11 2020
Jun 11 2020
Jun 9 2020
Jun 9 2020
In D22160#555029, @phil wrote:The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?
Thanks,
Phil
ps: remove xo_no_setlocale() call
Jun 8 2020
Jun 8 2020
In D22160#555029, @phil wrote:The "%hs" bits look good, but why do you add the call to xo_no_setlocale()?
Thanks,
Phil
Jun 7 2020
Jun 7 2020
In D25165#554658, @trasz wrote:And yeah, I think it’s a good idea to fix all of them. Still, this is fine too.
taskqueue(9): reference callout(9) instead of timeout(9)
ps: use %hs instead of %s format specifiers
Jun 6 2020
Jun 6 2020
yuripv added inline comments to D24919: nvi: fallback to iso8859-1 if utf-8 check failed and fileencoding/locale encoding is utf-8.
stats(7): fix bad Xr references and lint noise
In D25166#554560, @bjk wrote:I expect I should be the one committing this?
But I will hold off for a bit in case someone wants to respond to the 'kldstat' remark.