will look at this once remote access is available

Enable the msix rxtx vec

Committed in https://cgit.freebsd.org/src/commit/?id=450c3f8b3d259c7eb82488319aff45f1f6554aaf

ts=8

I would like to commit this on the 27th if there is no feedback.

Need to fix ixv

I'd like to commit this on the 27th (2 week feedback window) if there is no other discussion.

This may be a timing issue planning to check a few more things

Concept ACK. I don't have anything to test it on at the moment.

@imp For posterity, the way I generated the patches.. @erj maybe the DPDK team can use a method like this too so we stay in lockstep

Update with remaining catch-up diff

Seems fine to me.

@stevek @ian -- @mjg is reporting deadlocks with a heavy userspace load with this change on stable/12 on a 2GB arm platform.

In D31621#713873, @erj wrote:

In D31621#713497, @kbowling wrote:

I'd like to bias for action in any case because this all looks correct and needful so the sooner I can start committing the happier I'll be. I used a diff tool to do the first pass because I didn't realize the DPDK devs were doing incremental updates. In the past the shared code has landed as a big change with little associated revision information. After finding the commits I am leaning toward replaying the commits so we can preserve the why.

I think this is still something that needs to be discussed within the community. We have the capability to do that (see the Linux kernel!), but I already see issues with e.g. authorship from a large amount of commits not being that of a FreeBSD committer, as well as potentially polluting the FreeBSD git logs with lots of Intel Ethernet-only stuff.

In D31621#713498, @imp wrote:

In D31621#713448, @imp wrote:

In D31621#713435, @kbowling wrote:

@erj I think with the list of commits above I could replay them one by one. I'd like to get blanket approval to commit all them if folks want me to do it that way.

Just a process note:

If you wanted to do them as individual commits from dpdk, possibly with a final FreeBSD fixup commit that gave the same final answer, there's plenty of people that have done exactly that and unless @erj strongly objects, you could do that.
If people want to review the individual commits, then I'd strongly suggest using markj's git-arc.sh script that's in tools/tools/git since it makes it super easy to stage an entire branch into a number of phab reviews all at once.
If there's a bunch of files that are identical to dpdk, contact me off review and I can help you setup a vendor branch which may make doing imports in the future easier if this is going to be an ongoing thing.
And thanks for chasing all this down.

Address review

@erj I think with the list of commits above I could replay them one by one. I'd like to get blanket approval to commit all them if folks want me to do it that way.

In D31621#713196, @erj wrote:

I've got a couple comments:

• It seems a large part of this diff is formatting and the conversion of TRUE/FALSE to their lowercase counterparts; could that be split out into a different (possibly new ancestor) review?
• I don't think we actually support bypass adapters in ixgbe, according to Intel; the support was removed in the OOT driver I think but maybe it still exists upstream? I think there are hardly any people using them, either.
• All of us at Intel have GitHub accounts now, so you can annoy us and @imp with pull requests if you want to

@jrtc27 is there any issue to CHERI with the ether_addr cast like this? It is __packed.

Unsure why this didn't autoclose, committed in fc7682b17f3738573099b8b03f5628dcc8148adb

Rebase. Some ULP stuff for I219 that seems to work or not regress.

Ping, any vendor feedback here?

Address review feedback

PCSD is supposed to be set when using RSS features so I moved setting it into there.

Taking this so I can show you my changes, feel free to re-take after looking

Taking a look at this.. I suspect the 82574 MQ case will be mishandled let me check the various datasheets.

Address feedback

I forgot to add USES+=gl, but even with that the LIB_DEPENDS wasn't working as expected. Convert to explicit LIB_DEPENDS.

rebase

rebase on main, csum fix/cleanups broken out to a different review. address some of the feedback