Page MenuHomeFreeBSD

e1000: function prototype cleanup
ClosedPublic

Authored by kbowling on Oct 5 2021, 9:25 PM.

Details

Summary

Drop arguments of function prototypes since the file is mixed between listing arg names and not. I am unsure if there is a strong style(9) preference here , if desired I can add the correct arguments but it seems like it is hard to keep accurage and context aware editor features fulfill this role better in the modern era.

No functional change

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kbowling created this revision.

The closest thing style(9) has is:

In header files visible to userland applications, prototypes that are
visible must use either “protected” names (ones beginning with an
underscore) or no names with the types.  It is preferable to use
protected names.  E.g., use:

void    function(int);

or:

void    function(int _fd);

It doesn't offer any guidance for this particular situation AFAIK. I somewhat prefer to omit the parameter names for the reason you gave.

This revision is now accepted and ready to land.Oct 6 2021, 12:44 PM