Page MenuHomeFreeBSD

e1000: function prototype cleanup

Authored by kbowling on Oct 5 2021, 9:25 PM.
Referenced Files
Unknown Object (File)
Fri, May 26, 12:31 PM
Unknown Object (File)
Tue, May 9, 8:06 AM
Unknown Object (File)
Mon, May 8, 3:13 PM
Unknown Object (File)
Thu, May 4, 4:15 PM
Unknown Object (File)
Apr 5 2023, 8:13 PM
Unknown Object (File)
Feb 28 2023, 5:51 PM
Unknown Object (File)
Feb 16 2023, 11:42 AM
Unknown Object (File)
Feb 15 2023, 1:52 PM



Drop arguments of function prototypes since the file is mixed between listing arg names and not. I am unsure if there is a strong style(9) preference here , if desired I can add the correct arguments but it seems like it is hard to keep accurage and context aware editor features fulfill this role better in the modern era.

No functional change

Diff Detail

Lint Skipped
Tests Skipped

Event Timeline

kbowling created this revision.

The closest thing style(9) has is:

In header files visible to userland applications, prototypes that are
visible must use either “protected” names (ones beginning with an
underscore) or no names with the types.  It is preferable to use
protected names.  E.g., use:

void    function(int);


void    function(int _fd);

It doesn't offer any guidance for this particular situation AFAIK. I somewhat prefer to omit the parameter names for the reason you gave.

This revision is now accepted and ready to land.Oct 6 2021, 12:44 PM