ixgbe: Avoid sbuf_trim in sysctl handler

[kbowling]

Summary

This was an error, we cannot use sbuf_trim(9) in the ixgbe_get_phy_firmware_version function because it also gets called in the context of sbuf_new_for_sysctl(9). sbuf(9) explains the interaction with drain functions as used by sbuf_new_for_sysctl(9).

MFC after: 1 day
Fixes: 7660e4ea5cb7

Test Plan

Tested on X552.

[imp]

Suggested approach which I think might be simpler, but the only mandatory thing is the final space that got left in.

sys/dev/ixgbe/if_ix.c

4698

I'd add a const char *space = ""; here

4706–4708

Then add space =" "; here with {}

4711

and use space here instead of this express....

4712

with the same space = " "; here.

4717

and replace this with space.

4723

I think you missed one of the trailing white spaces here.. It would have been trimmed before.

[kbowling]

Address review

[imp]

Looks good to me!