if_bge: Add support for WOL
AcceptedPublic
Actions

Authored by cy on Sep 4 2021, 1:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 15 2024, 5:03 PM

	Unknown Object (File)
	Mar 10 2024, 7:12 AM

	Unknown Object (File)
	Dec 25 2023, 3:02 AM

	Unknown Object (File)
	Dec 22 2023, 10:03 PM

	Unknown Object (File)
	Nov 6 2023, 3:32 AM

	Unknown Object (File)
	Nov 4 2023, 7:26 AM

	Unknown Object (File)
	Nov 3 2023, 3:37 PM

	Unknown Object (File)
	Oct 5 2023, 2:26 AM

View All 21 Files

Subscribers

kbowling

peter_libassi.se

Details

Reviewers

marius
glebius
imp
avg
tychon
kbowling

Group Reviewers

network

Summary

Add WOL support to bge(4).

With this patch if_bge receives WOL support.

Like other NICs in FreeBSD when any of the WOL flags is set the NIC is
set to WOL upon NIC shutdown.

This fixes the following PRs 218579, 171744, 177184, and 184718.

Test Plan

Used by myself over the last five years. Tested by those in the listed PRs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cy requested review of this revision.Sep 4 2021, 1:50 PM

cy created this revision.

peter_libassi.se added a subscriber: peter_libassi.se.Sep 4 2021, 5:09 PM

Seems fine to me.

As a separate discussion I wonder about the expected default behavior here over time, there are some tradeoffs to defaulting WOL enabled (which many drivers do via initializing IFCAP as such) versus checking firmware state in various client Ethernet parts.

This revision is now accepted and ready to land.Sep 5 2021, 4:33 PM

Agreed, default WOL should be a policy decision whether all interfaces default to on or off. Personally, it doesn't matter to me however all should be the same.