bge: Convert driver to CTLFLAG_MPSAFE
Needs ReviewPublic
Actions

Authored by guest-seuros on Fri, Jan 9, 1:29 PM.

Tags

None

Referenced Files

	F141911752: D54614.diff
	Mon, Jan 12, 10:15 AM

	F141903626: D54614.diff
	Mon, Jan 12, 7:08 AM

	Unknown Object (File)
	Sat, Jan 10, 6:44 PM

	Unknown Object (File)
	Sat, Jan 10, 3:54 PM

	Unknown Object (File)
	Sat, Jan 10, 3:09 PM

	Unknown Object (File)
	Sat, Jan 10, 4:45 AM

	Unknown Object (File)
	Sat, Jan 10, 4:43 AM

	Unknown Object (File)
	Sat, Jan 10, 3:00 AM

View All 11 Files

Subscribers

imp

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Summary

Replace CTLFLAG_NEEDGIANT with CTLFLAG_MPSAFE for all sysctls.
The driver uses mutex bge_mtx for hardware access and does not
require Giant lock.

Sysctls converted:

Debug sysctls (debug_info, reg_read, ape_read, mem_read)
Statistics sysctls (read-only hardware stats)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69749
Build 66632: arc lint + arc unit

Event Timeline

guest-seuros created this revision.Fri, Jan 9, 1:29 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 9, 1:29 PM

guest-seuros requested review of this revision.Fri, Jan 9, 1:29 PM

Harbormaster completed remote builds in B69749: Diff 169377.Fri, Jan 9, 1:29 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

bge/

if_bge.c

10 lines

Diff 169377

View Options

bge: Convert driver to CTLFLAG_MPSAFENeeds ReviewPublicActions