Differential D32087

e1000: Re-arm link changes
ClosedPublic
Actions

Authored by kbowling on Sep 23 2021, 9:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jan 10, 2:39 PM

	Unknown Object (File)
	Dec 6 2024, 7:15 AM

	Unknown Object (File)
	Nov 22 2024, 2:35 PM

	Unknown Object (File)
	Nov 22 2024, 9:30 AM

	Unknown Object (File)
	Nov 17 2024, 12:00 PM

	Unknown Object (File)
	Sep 30 2024, 10:24 PM

	Unknown Object (File)
	Sep 30 2024, 3:20 PM

	Unknown Object (File)
	Sep 27 2024, 5:34 PM

View All 64 Files

Subscribers

None

Details

Reviewers

franco_opnsense.org
markj

Group Reviewers

Intel Networking

Summary

Pointy-hat to me, not sure how this was working on some of these NICs.

PR:             258551
Reported by:    Franco Fichtner <franco@opnsense.org>, t_uemura@macome.co.jp
Fixes:          eea55de7b108 e1000: Rework em_msi_link interrupt filter
MFC after:      1 day

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling requested review of this revision.Sep 23 2021, 9:08 PM

kbowling created this revision.

This may be a timing issue planning to check a few more things

kbowling updated this revision to Diff 95636.Sep 24 2021, 5:57 PM

markj accepted this revision.Sep 24 2021, 6:31 PM

This revision is now accepted and ready to land.Sep 24 2021, 6:31 PM

Thanks for the find! Looks reasonable to bring in. I will try to get more test coverage from our users, though feedback was low on this particular hang ;(

Committed in https://cgit.freebsd.org/src/commit/?id=450c3f8b3d259c7eb82488319aff45f1f6554aaf