Differential D32087

e1000: Re-arm link changes
ClosedPublic
Actions

Authored by kbowling on Sep 23 2021, 9:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 13, 6:45 PM

	Unknown Object (File)
	Sun, Mar 31, 11:44 AM

	Unknown Object (File)
	Jan 26 2024, 2:18 AM

	Unknown Object (File)
	Dec 20 2023, 6:08 AM

	Unknown Object (File)
	Dec 17 2023, 3:51 AM

	Unknown Object (File)
	Dec 14 2023, 9:59 AM

	Unknown Object (File)
	Dec 10 2023, 1:30 AM

	Unknown Object (File)
	Nov 13 2023, 5:24 PM

View All 39 Files

Subscribers

None

Details

Reviewers

franco_opnsense.org
markj

Group Reviewers

Intel Networking

Summary

Pointy-hat to me, not sure how this was working on some of these NICs.

PR:             258551
Reported by:    Franco Fichtner <franco@opnsense.org>, t_uemura@macome.co.jp
Fixes:          eea55de7b108 e1000: Rework em_msi_link interrupt filter
MFC after:      1 day

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling requested review of this revision.Sep 23 2021, 9:08 PM

kbowling created this revision.

This may be a timing issue planning to check a few more things

kbowling updated this revision to Diff 95636.Sep 24 2021, 5:57 PM

markj accepted this revision.Sep 24 2021, 6:31 PM

This revision is now accepted and ready to land.Sep 24 2021, 6:31 PM

Thanks for the find! Looks reasonable to bring in. I will try to get more test coverage from our users, though feedback was low on this particular hang ;(

Committed in https://cgit.freebsd.org/src/commit/?id=450c3f8b3d259c7eb82488319aff45f1f6554aaf