Page MenuHomeFreeBSD

stable/12: iflib: fix potential NULL dereference
ClosedPublic

Authored by kp on Aug 31 2021, 6:31 PM.
Tags
None
Referenced Files
F168352846: D31758.diff
Thu, Aug 27, 6:11 PM
Unknown Object (File)
Wed, Aug 26, 7:40 AM
Unknown Object (File)
Sun, Aug 23, 9:35 AM
Unknown Object (File)
Sat, Aug 22, 9:58 AM
Unknown Object (File)
Sat, Aug 22, 9:03 AM
Unknown Object (File)
Fri, Aug 21, 6:30 PM
Unknown Object (File)
Fri, Aug 21, 11:16 AM
Unknown Object (File)
Thu, Aug 20, 7:24 PM
Subscribers

Details

Summary

iflib_softirq_alloc_generic() can be called with a NULL irq parameter
(as done by for example the bnxt and ixl drivers). If
iflib_irq_set_affinity() then returns an error we'd try to dereference
the NULL irq pointer.

Check irq, and pass '-1' (which taskqgroup_attach() expects) if we don't
have an irq.

Direct commit to stable/12, because this issue does not exist on main
and stable/13.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Aug 31 2021, 6:31 PM
This revision is now accepted and ready to land.Aug 31 2021, 6:47 PM
This revision was automatically updated to reflect the committed changes.