Page MenuHomeFreeBSD

stable/12: iflib: fix potential NULL dereference
ClosedPublic

Authored by kp on Aug 31 2021, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 3:21 AM
Unknown Object (File)
Wed, Oct 1, 6:01 AM
Unknown Object (File)
Wed, Sep 24, 12:16 PM
Unknown Object (File)
Sep 12 2025, 11:11 AM
Unknown Object (File)
Sep 11 2025, 3:15 PM
Unknown Object (File)
Aug 14 2025, 8:36 PM
Unknown Object (File)
Aug 6 2025, 1:09 PM
Unknown Object (File)
Jul 18 2025, 1:14 AM
Subscribers

Details

Summary

iflib_softirq_alloc_generic() can be called with a NULL irq parameter
(as done by for example the bnxt and ixl drivers). If
iflib_irq_set_affinity() then returns an error we'd try to dereference
the NULL irq pointer.

Check irq, and pass '-1' (which taskqgroup_attach() expects) if we don't
have an irq.

Direct commit to stable/12, because this issue does not exist on main
and stable/13.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Aug 31 2021, 6:31 PM
This revision is now accepted and ready to land.Aug 31 2021, 6:47 PM
This revision was automatically updated to reflect the committed changes.