Paths

Table of Contentst

Differential D31457

e1000: Simplify rctl/srrctl buffer size init
ClosedPublic
Actions

Authored by kbowling on Aug 8 2021, 5:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 24, 7:21 AM

	Unknown Object (File)
	Fri, May 22, 4:58 AM

	Unknown Object (File)
	Thu, May 21, 5:53 PM

	Unknown Object (File)
	Wed, May 20, 1:49 PM

	Unknown Object (File)
	Wed, May 20, 3:35 AM

	Unknown Object (File)
	Tue, May 19, 6:25 PM

	Unknown Object (File)
	Sun, May 17, 2:53 PM

	Unknown Object (File)
	Tue, Apr 28, 11:08 PM

Subscribers

None

Details

Reviewers

markj
emaste
grehan

Group Reviewers

Intel Networking

Commits

rG4188e54d3fa7: e1000: rctl/srrctl buffer size init, rfctl fix
rG15b57cbfde4d: e1000: rctl/srrctl buffer size init, rfctl fix
rG12e8addd320d: e1000: rctl/srrctl buffer size init, rfctl fix

Summary

Simplify the setup of srrctl.BSIZEPKT on igb class NICs.
Simplify the setup of rctl.BSIZE on lem and em class NICs.
Don't try to touch rfctl on lem class NICs.
Manipulate rctl.BSEX correctly on lem and em class NICs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kbowling requested review of this revision.Aug 8 2021, 5:58 AM

kbowling created this revision.

kbowling added inline comments.Aug 8 2021, 6:01 AM

sys/dev/e1000/if_em.c
3173	https://cgit.freebsd.org/src/tree/sys/dev/ixgbe/if_ix.c#n669
3339	https://cgit.freebsd.org/src/tree/sys/dev/ixgbe/if_ix.c#n706 https://cgit.freebsd.org/src/tree/sys/dev/ixgbe/if_ix.c#n727

kbowling updated this revision to Diff 93397.Aug 8 2021, 6:36 AM

kbowling updated this revision to Diff 93398.Aug 8 2021, 6:49 AM

kbowling updated this revision to Diff 93399.Aug 8 2021, 7:09 AM

kbowling edited the summary of this revision. (Show Details)Aug 8 2021, 7:12 AM

markj accepted this revision.Aug 10 2021, 7:20 PM

markj added inline comments.

sys/dev/e1000/if_em.c
3228–3245	Perhaps move the definition of `rfctl` into this block.
3407–3414

This revision is now accepted and ready to land.Aug 10 2021, 7:20 PM

Closed by commit rG12e8addd320d: e1000: rctl/srrctl buffer size init, rfctl fix (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyAug 10 2021, 7:48 PM

This revision was automatically updated to reflect the committed changes.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG12e8addd320d: e1000: rctl/srrctl buffer size init, rfctl fix.

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG15b57cbfde4d: e1000: rctl/srrctl buffer size init, rfctl fix.Aug 17 2021, 1:36 AM

Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG4188e54d3fa7: e1000: rctl/srrctl buffer size init, rfctl fix.Aug 17 2021, 1:57 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

76 lines

Diff 93500

sys/dev/e1000/if_em.c

Loading...